[Extension ServiceWorkers] Blink: Passing v8::context to extensions dispatcher

Source/core/workers/WorkerThread.cpp

Index: Source/core/workers/WorkerThread.cpp
diff --git a/Source/core/workers/WorkerThread.cpp b/Source/core/workers/WorkerThread.cpp
index 5c0b410876bd36448b622d837a969523647b7de1..afcc013a55dbb06b92ea2421d3ed74e5b9caeaa6 100644
--- a/Source/core/workers/WorkerThread.cpp
+++ b/Source/core/workers/WorkerThread.cpp
@@ -250,6 +250,10 @@ void WorkerThread::initialize(PassOwnPtr<WorkerThreadStartupData> startupData)
         script->initializeContextIfNeeded();
     m_workerGlobalScope->workerInspectorController()->workerContextInitialized(startMode == PauseWorkerGlobalScopeOnStart);
 
+    if (script->scriptState()->contextIsValid()) {

[dcheng, 2015/08/05 00:04:53]

How come we didn't need to check if the context was valid before?

[annekao, 2015/08/05 16:43:02]

I initially put this check in to address what falken said about how it may not
be valid.  But, after rereading his comment I realized I misunderstood it.  This
can be removed if there's no need for it.

[falken, 2015/08/06 03:37:20]

Hm, I was thinking of a different case, but it looks like it's still needed. In
the case of isExecutionForbidden(),  initializeContextIfNeeded() is not called,
so I think the context would be invalid. Probably it doesn't make sense to call
didInitializeWorkerContext() in that case.

+        m_workerReportingProxy.didInitializeWorkerContext();
+    }
+
     OwnPtrWillBeRawPtr<CachedMetadataHandler> handler(workerGlobalScope()->createWorkerScriptCachedMetadataHandler(scriptURL, cachedMetaData.get()));
     bool success = script->evaluate(ScriptSourceCode(sourceCode, scriptURL), nullptr, handler.get(), v8CacheOptions);
     m_workerGlobalScope->didEvaluateWorkerScript();