[Extension ServiceWorkers] Blink: Passing v8::context to extensions dispatcher

Source/core/workers/WorkerThread.cpp

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 237 matching lines @@
     WorkerScriptController* script = m_workerGlobalScope->script();
     if (!script->isExecutionForbidden())
         script->initializeContextIfNeeded();
     m_workerGlobalScope->workerInspectorController()->workerContextInitialized(startMode == PauseWorkerGlobalScopeOnStart);
 
     OwnPtrWillBeRawPtr<CachedMetadataHandler> handler(workerGlobalScope()->createWorkerScriptCachedMetadataHandler(scriptURL, cachedMetaData.get()));
     bool success = script->evaluate(ScriptSourceCode(sourceCode, scriptURL), nullptr, handler.get(), v8CacheOptions);
     m_workerGlobalScope->didEvaluateWorkerScript();
     m_workerReportingProxy.didEvaluateWorkerScript(success);
 
+    ScriptState::Scope scope(script->scriptState());
+    m_workerReportingProxy.didInitializeWorkerContext(script->context());

[falken, 2015/08/03 01:55:14]

It seems to make sense to call didInitializeWorkerContext where
workerContextInitialized() is called in line 251.

As written this waits for evaluation to complete. So if the listener wants to
set some flag on the context as the the chromium patch seems to do, the initial
evaluation of the script wouldn't be under the flag (only events that fired
after would have it).

Also consider the while(true) {} case. If the script never terminates,
didInitializeWorkerContext() is never called in the current patch. In the case
of SW there's a browser-side timeout that sends a message to the renderer to
terminate execution and shutdown the thread. We should verify the sequence of
what happens in that case: I'm not sure whether script->context() is valid after
termination.

+
     postInitialize();
 
     m_webScheduler->postIdleTaskAfterWakeup(FROM_HERE, WTF::bind<double>(&WorkerThread::performIdleWork, this));
 }
 
 void WorkerThread::shutdown()
 {
     ASSERT(isCurrentThread());
     {
         MutexLocker lock(m_threadStateMutex);
@@ skipping 239 matching lines @@
     InspectorInstrumentation::didLeaveNestedRunLoop(m_workerGlobalScope.get());
 }
 
 void WorkerThread::setWorkerInspectorController(WorkerInspectorController* workerInspectorController)
 {
     MutexLocker locker(m_workerInspectorControllerMutex);
     m_workerInspectorController = workerInspectorController;
 }
 
 } // namespace blink