Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1264893002: Runtime CPU detection for rsqrt(). (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
jvanverth1, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Runtime CPU detection for rsqrt(). This enables the NEON sk_float_rsqrt() code for configurations that have NEON at run-time but not compile-time. These devices will see about a 2x (1.26 -> 2.33) slowdown in sk_float_rsqrt(), but it should be more precise than our portable fallback. (When inlined, the portable fallback and the NEON code are almost identical in speed. The only difference is precision. Going through a function pointer is causing all this slowdown. This is a good example of a place where Skia really benefits from compile-time NEON.) BUG=skia:4117, skia:4114 No public API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/f684a78d9ea988883c9b2c7bcc4ea4d5e68bd998

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M include/core/SkFloatingPoint.h View 2 chunks +4 lines, -9 lines 0 comments Download
M src/core/SkOpts.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/core/SkOpts.cpp View 1 chunk +14 lines, -1 line 0 comments Download
M src/opts/SkOpts_neon.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264893002/1
5 years, 4 months ago (2015-07-30 15:37:40 UTC) #2
mtklein_C
5 years, 4 months ago (2015-07-30 15:44:36 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-30 15:45:10 UTC) #6
jvanverth1
lgtm
5 years, 4 months ago (2015-07-30 16:28:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264893002/1
5 years, 4 months ago (2015-07-30 16:29:04 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 16:29:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f684a78d9ea988883c9b2c7bcc4ea4d5e68bd998

Powered by Google App Engine
This is Rietveld 408576698