Add simple script to regenerate expected results.

Add simple script to regenerate expected results.

(I've been doing this by hand for far too long).

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/3fc30f0778ff0bfb1c61e7994e6472a34bdc98bd

[Tom Sepez, 2015-07-30 17:01:17]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-07-30 17:01:17]

Lei, small review.  Sorry not python.

[Lei Zhang, 2015-07-30 19:15:19]

This probably won't run correctly on Windows. (Maybe in cygwin?) Do you care
about that?

[Tom Sepez, 2015-07-30 19:34:37]

On 2015/07/30 19:15:19, Lei Zhang wrote:
> This probably won't run correctly on Windows. (Maybe in cygwin?) Do you care
> about that?
Not yet.  At the moment, all expected results are generated on linux and
suppressed
if they don't work elsewhere.  we don't have per-platform expected files yet.

[Lei Zhang, 2015-07-30 21:18:17]

https://codereview.chromium.org/1264873005/diff/1/testing/tools/make_expected.sh
File testing/tools/make_expected.sh (right):

https://codereview.chromium.org/1264873005/diff/1/testing/tools/make_expected...
testing/tools/make_expected.sh:10: for RESULT in $RESULTS ; do
This won't work correctly if there's spaces in file names. You may want to check
and bail out if $INFILE has spaces.

I know we don't have any files with spaces in the filenames right now, but I'd
guard against that case.

[Tom Sepez, 2015-07-30 22:44:53]

On 2015/07/30 21:18:17, Lei Zhang wrote:
>
https://codereview.chromium.org/1264873005/diff/1/testing/tools/make_expected.sh
> File testing/tools/make_expected.sh (right):
> 
>
https://codereview.chromium.org/1264873005/diff/1/testing/tools/make_expected...
> testing/tools/make_expected.sh:10: for RESULT in $RESULTS ; do
> This won't work correctly if there's spaces in file names. You may want to
check
> and bail out if $INFILE has spaces.
> 
> I know we don't have any files with spaces in the filenames right now, but I'd
> guard against that case.

Hmm.  passing this something like:
make_expected.sh 'testing/corpus/fx/FRC_3.5_part2/FRC_3.5_P 
3616_Password_1.pdf' 'testing/corpus/fx/FRC_3.5_part2/FRC_3.5_P 
3616_Password_2.pdf'

blows out earlier as it tries to "shift" its way through 4 files.  Not sure what
to do about that ...

[Lei Zhang, 2015-07-30 23:01:51]

On 2015/07/30 22:44:53, Tom Sepez wrote:
> On 2015/07/30 21:18:17, Lei Zhang wrote:
> >
>
https://codereview.chromium.org/1264873005/diff/1/testing/tools/make_expected.sh
> > File testing/tools/make_expected.sh (right):
> > 
> >
>
https://codereview.chromium.org/1264873005/diff/1/testing/tools/make_expected...
> > testing/tools/make_expected.sh:10: for RESULT in $RESULTS ; do
> > This won't work correctly if there's spaces in file names. You may want to
> check
> > and bail out if $INFILE has spaces.
> > 
> > I know we don't have any files with spaces in the filenames right now, but
I'd
> > guard against that case.
> 
> Hmm.  passing this something like:
> make_expected.sh 'testing/corpus/fx/FRC_3.5_part2/FRC_3.5_P 
> 3616_Password_1.pdf' 'testing/corpus/fx/FRC_3.5_part2/FRC_3.5_P 
> 3616_Password_2.pdf'
> 
> blows out earlier as it tries to "shift" its way through 4 files.  Not sure
what
> to do about that ...

I was thinking we add:

set -e

and after INFILE="$1", add:

echo $INFILE | grep -qs ' ' && echo space in filename detected && exit 1

[Tom Sepez, 2015-07-30 23:45:46]

Gotcha.  Thanks.

[Lei Zhang, 2015-07-30 23:47:50]

lgtm

[Tom Sepez, 2015-07-30 23:48:32]

Committed patchset #2 (id:20001) manually as
3fc30f0778ff0bfb1c61e7994e6472a34bdc98bd (presubmit successful).