Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1264823003: VectorICs: --print-ast now prints allocated vector slots (Closed)

Created:
5 years, 4 months ago by mvstanton
Modified:
5 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

VectorICs: --print-ast now prints allocated vector slots Looks like this: --- AST --- FUNC . NAME "foo" . INFERRED NAME "" . RETURN . . PROPERTY ICSlot(0, LOAD_IC) . . . VAR PROXY ICSlot(1, LOAD_IC) (mode = DYNAMIC_GLOBAL) "a" . . . NAME x BUG= R=rossberg@chromium.org Committed: https://crrev.com/7a172d54ba1e17fc12cb3a54ca83e39dd3b60ef8 Cr-Commit-Position: refs/heads/master@{#29928}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M src/prettyprinter.cc View 5 chunks +26 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mvstanton
Hi Andreas, Here is the ast pretty printing support for vectors we discussed yesterday. Thanks ...
5 years, 4 months ago (2015-07-30 10:44:06 UTC) #1
rossberg
lgtm
5 years, 4 months ago (2015-07-30 10:57:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264823003/1
5 years, 4 months ago (2015-07-30 10:59:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 11:09:48 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 11:10:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a172d54ba1e17fc12cb3a54ca83e39dd3b60ef8
Cr-Commit-Position: refs/heads/master@{#29928}

Powered by Google App Engine
This is Rietveld 408576698