Issue 1264813004: Add tracing to all url requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1264813004: Add tracing to all url requests. (Closed)

Created:
5 years, 4 months ago by qsr

Modified:
5 years, 4 months ago

Reviewers:
ppi

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/monet.git@master

Target Ref:
refs/heads/master

Project:
monet

Visibility:
Public.

More Reviews

Description

Add tracing to all url requests. R=ppi@chromium.org Committed: https://github.com/domokit/monet1b87e90f670ebfee2b55df21b07dc37dc628fe40

Patch Set 1 #

Total comments: 1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -4 lines)			Patch
	M	mojo/services/network/url_loader_impl.cc	View		3 chunks	+22 lines, -4 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ppi

https://codereview.chromium.org/1264813004/diff/1/mojo/services/network/url_loader_impl.cc File mojo/services/network/url_loader_impl.cc (right): https://codereview.chromium.org/1264813004/diff/1/mojo/services/network/url_loader_impl.cc#newcode327 mojo/services/network/url_loader_impl.cc:327: &RunCallbackAndTrace, "URLLoaderImpl::FollowRedirect", this, callback); Can the id (here being ...

5 years, 4 months ago (2015-08-03 14:50:23 UTC) #2

ppi

lgtm if the answer is "yes, provided that are not overlapping"

5 years, 4 months ago (2015-08-03 14:54:40 UTC) #3

qsr

5 years, 4 months ago (2015-08-04 08:07:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1b87e90f670ebfee2b55df21b07dc37dc628fe40 (presubmit successful).

Expand Messages | Collapse Messages