Issue 1264763003: Don't emulate Sky server when --sky is passed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1264763003: Don't emulate Sky server when --sky is passed. (Closed)

Created:
5 years, 4 months ago by ppi

Modified:
5 years, 4 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Description

Don't emulate Sky server when --sky is passed. The support for running Sky apps within a Mojo checkout broke when sky_engine moved out - as sky SDK packages are no longer built in Mojo checkout, we are not in position to emulate Sky server as we used to do. Running Sky apps is still possible, but one needs to indicate where sky_viewer is and run Sky server themselves. This patch updates the documentation and removes broken support. Fixes domokit/devtools#24. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/11e4fcd71e3283ec4c28e91aca581b03bef24327

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 4 months ago

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -66 lines)
M	README.md	View	1 chunk	+10 lines, -22 lines	0 comments
M	mojo/devtools/common/README.md	View	1 chunk	+40 lines, -2 lines	0 comments
M	mojo/devtools/common/devtoolslib/paths.py	View	1 chunk	+0 lines, -3 lines	0 comments
M	mojo/devtools/common/devtoolslib/shell_arguments.py	View	3 chunks	+14 lines, -28 lines	0 comments
M	mojo/devtools/common/mojo_run	View	2 chunks	+0 lines, -11 lines	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ppi

5 years, 4 months ago (2015-07-31 12:00:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
11e4fcd71e3283ec4c28e91aca581b03bef24327 (presubmit successful).

Expand Messages | Collapse Messages