Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1264743002: Make video encoder/decoder test faster (Closed)

Created:
5 years, 4 months ago by Sergey Ulanov
Modified:
5 years, 4 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make video encoder/decoder test faster Reduced size of the frames used in the tests to make them faster. Previously all Video tests in remoting_unittests were taking more than 10 seconds, now thay take less than 4 BUG=514404 Committed: https://crrev.com/fc59cb43df0e4eb77bc2916ab37d36598eabd4f2 Cr-Commit-Position: refs/heads/master@{#341206}

Patch Set 1 #

Patch Set 2 : Fix ASan failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -69 lines) Patch
M remoting/codec/codec_test.cc View 1 7 chunks +42 lines, -64 lines 0 comments Download
M remoting/codec/video_encoder_vpx_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Sergey Ulanov
5 years, 4 months ago (2015-07-29 22:13:54 UTC) #2
Jamie
LGTM, but please also remove the suppression added by https://codereview.chromium.org/1254203005 (in this CL, or a ...
5 years, 4 months ago (2015-07-29 23:36:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264743002/1
5 years, 4 months ago (2015-07-30 16:10:53 UTC) #5
Sergey Ulanov
On 2015/07/29 23:36:01, Jamie wrote: > LGTM, but please also remove the suppression added by ...
5 years, 4 months ago (2015-07-30 16:11:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/33988)
5 years, 4 months ago (2015-07-30 16:28:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264743002/20001
5 years, 4 months ago (2015-07-30 21:56:16 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-30 22:19:34 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 22:20:18 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fc59cb43df0e4eb77bc2916ab37d36598eabd4f2
Cr-Commit-Position: refs/heads/master@{#341206}

Powered by Google App Engine
This is Rietveld 408576698