Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1264733003: [CSS Grid Layout] Only stretch tracks with 'auto' max-content sizing. (Closed)

Created:
5 years, 4 months ago by jfernandez
Modified:
5 years, 4 months ago
CC:
blink-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@auto-valid-for-max-track
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[CSS Grid Layout] Only stretch tracks with 'auto' max-content sizing. There was an ambiguity regarding the meaning of the 'auto' sized tracks, whcih are the ones allowed to be stretched by Content Alignment properties. this issue has been clarified by the spec editors and now we consider them as the ones with an 'auto' max-content sizing function. BUG=249451, 376823 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200506

Patch Set 1 #

Patch Set 2 : Patch rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -3 lines) Patch
A LayoutTests/fast/css-grid-layout/grid-content-alignment-stretch-only-valid-for-auto-sized-tracks.html View 1 chunk +144 lines, -0 lines 0 comments Download
A LayoutTests/fast/css-grid-layout/grid-content-alignment-stretch-only-valid-for-auto-sized-tracks-expected.txt View 1 chunk +23 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutGrid.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
jfernandez
5 years, 4 months ago (2015-07-31 16:26:34 UTC) #2
svillar
lgtm
5 years, 4 months ago (2015-08-03 07:23:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264733003/1
5 years, 4 months ago (2015-08-13 14:42:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/119414)
5 years, 4 months ago (2015-08-13 15:04:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264733003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264733003/20001
5 years, 4 months ago (2015-08-13 22:33:56 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 01:57:41 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200506

Powered by Google App Engine
This is Rietveld 408576698