Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 1264723002: [d8 worker] Fix regression when serializing very large arraybuffer (Closed)

Created:
5 years, 4 months ago by binji
Modified:
5 years, 4 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[d8 worker] Fix regression when serializing very large arraybuffer BUG=chromium:514081 R=jarin@chromium.org LOG=n Committed: https://crrev.com/df1f72bbf1cafb3338cce88b88013b377531eb82 Cr-Commit-Position: refs/heads/master@{#29982}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : fix test failures #

Patch Set 4 : merge master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M src/d8.cc View 1 2 3 2 chunks +4 lines, -5 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-514081.js View 1 2 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
binji
5 years, 4 months ago (2015-07-30 17:15:21 UTC) #1
Jarin
lgtm
5 years, 4 months ago (2015-08-03 05:04:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264723002/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264723002/30001
5 years, 4 months ago (2015-08-03 16:34:36 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4652)
5 years, 4 months ago (2015-08-03 16:38:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264723002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264723002/50001
5 years, 4 months ago (2015-08-03 16:40:59 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:50001)
5 years, 4 months ago (2015-08-03 17:07:53 UTC) #10
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/df1f72bbf1cafb3338cce88b88013b377531eb82 Cr-Commit-Position: refs/heads/master@{#29982}
5 years, 4 months ago (2015-08-03 17:08:09 UTC) #11
saper
On 2015/08/03 17:08:09, commit-bot: I haz the power wrote: > Patchset 4 (id:??) landed as ...
5 years, 4 months ago (2015-08-08 23:33:04 UTC) #12
saper
5 years, 4 months ago (2015-08-09 00:22:03 UTC) #13
Message was sent while issue was closed.
On 2015/08/08 23:33:04, saper wrote:
> On 2015/08/03 17:08:09, commit-bot: I haz the power wrote:
> > Patchset 4 (id:??) landed as
> > https://crrev.com/df1f72bbf1cafb3338cce88b88013b377531eb82
> > Cr-Commit-Position: refs/heads/master@{#29982}
> 
> The test crashes on FreeBSD/x64 as of
> https://crrev.com/73ae23b5dc9bd816474688e74b9b768a09b9711f
> 
> #0  memset () at /usr/src/lib/libc/amd64/string/memset.S:51
> #1  0x00000000004253b1 in v8::(anonymous
> namespace)::ShellArrayBufferAllocator::Allocate (
>     this=0x7fffffffe4a8, length=2147483648) at ../src/d8.cc:84

This crash is a SIGKILL because the machine ran out of virtual memory (no swap
space). Please disregard, sorry for noise!

Powered by Google App Engine
This is Rietveld 408576698