Lazily require types when validating Extensions API calls

chrome/renderer/resources/extensions/schema_utils.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Routines used to validate and normalize arguments.
 
 var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
 var chrome = requireNative('chrome').GetChrome();
+var loadRefType = require('utils').loadRefType;
 
 // TODO(benwells): unit test this file.
 // JSONSchemaValidator is not loaded in unit tests.
 var validate;
 if (chromeHidden.JSONSchemaValidator) {
   var schemaValidator = new chromeHidden.JSONSchemaValidator();
 
   // Validate arguments.
   validate = function(args, parameterSchemas) {
     if (args.length > parameterSchemas.length)
@@ skipping 24 matching lines @@
     }
   };
 } else {
   validate = function() {};
 }
 
 // Generate all possible signatures for a given API function.
 function getSignatures(parameterSchemas) {
   if (parameterSchemas.length === 0)
     return [[]];
+  for (var i = 0; i < parameterSchemas.length; i++) {
+    if ('$ref' in parameterSchemas[i]) {
+      var type = loadRefType(parameterSchemas[i]['$ref']);
+      type.name = parameterSchemas[i].name;
+      parameterSchemas[i] = type;
+    }
+  }

[not at google - send to devlin, 2013/03/21 00:01:13]

is this necessary, the schema validator knows how to load $refs already?

[cduvall, 2013/03/21 00:59:51]

Hmm, it seemed necessary when I did it, but now I can't find the test that
failed. I'll take it out.

   var signatures = [];
   var remaining = getSignatures(parameterSchemas.slice(1));
   for (var i = 0; i < remaining.length; i++)
-    signatures.push([parameterSchemas[0]].concat(remaining[i]))
+    signatures.push([parameterSchemas[0]].concat(remaining[i]));
   if (parameterSchemas[0].optional)
     return signatures.concat(remaining);
   return signatures;
 };
 
 // Return true if arguments match a given signature's schema.
 function argumentsMatchSignature(args, candidateSignature) {
   if (args.length != candidateSignature.length)
     return false;
   for (var i = 0; i < candidateSignature.length; i++) {
@@ skipping 87 matching lines @@
         return true;
     }
   }
   return false;
 };
 
 exports.isFunctionSignatureAmbiguous = isFunctionSignatureAmbiguous;
 exports.normalizeArgumentsAndValidate = normalizeArgumentsAndValidate;
 exports.schemaValidator = schemaValidator;
 exports.validate = validate;