Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: runtime/vm/parser.cc

Issue 12647012: Properly handle cascades in top-level functions (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/cascade_in_expression_function_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 20275)
+++ runtime/vm/parser.cc (working copy)
@@ -9891,9 +9891,15 @@
void Parser::SkipSelectors() {
while (true) {
- if ((CurrentToken() == Token::kPERIOD) ||
- (CurrentToken() == Token::kCASCADE)) {
+ if (CurrentToken() == Token::kCASCADE) {
ConsumeToken();
+ if (CurrentToken() == Token::kLBRACK) {
+ continue; // Consume [ in next loop iteration.
+ } else {
+ ExpectIdentifier("identifier or [ expected after ..");
+ }
+ } else if (CurrentToken() == Token::kPERIOD) {
+ ConsumeToken();
ExpectIdentifier("identifier expected");
} else if (CurrentToken() == Token::kLBRACK) {
ConsumeToken();
« no previous file with comments | « no previous file | tests/language/cascade_in_expression_function_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698