Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1264683004: Add empty implementation of GetSystemMemoryInfo for IOS. (Closed)

Created:
5 years, 4 months ago by Georges Khalil
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, erikwright+watch_chromium.org, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add empty implementation of GetSystemMemoryInfo for IOS. BUG=514221 Committed: https://crrev.com/ae7209aeafdcb56f6761aeffe27f992fe2571a04 Cr-Commit-Position: refs/heads/master@{#342688}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : thestig@ comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M base/process/process_metrics.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M base/process/process_metrics_ios.cc View 1 2 chunks +12 lines, -0 lines 0 comments Download
M base/process/process_metrics_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
Georges Khalil
thakis@, PTAL. As per our earlier discussion in 1257813002, I added an empty implementation of ...
5 years, 4 months ago (2015-08-05 19:35:11 UTC) #8
Georges Khalil
I just realized I had the wrong reviewer! Nico, sorry for the noise. -thakis@ +thestig@
5 years, 4 months ago (2015-08-10 18:24:21 UTC) #10
Lei Zhang
lgtm https://codereview.chromium.org/1264683004/diff/80001/base/process/process_metrics.h File base/process/process_metrics.h (right): https://codereview.chromium.org/1264683004/diff/80001/base/process/process_metrics.h#newcode251 base/process/process_metrics.h:251: // GetSystemMemoryInfo. Total/free swap memory are available on ...
5 years, 4 months ago (2015-08-10 18:42:31 UTC) #11
Georges Khalil
Thanks, addressed comments. Landing this. https://codereview.chromium.org/1264683004/diff/80001/base/process/process_metrics.h File base/process/process_metrics.h (right): https://codereview.chromium.org/1264683004/diff/80001/base/process/process_metrics.h#newcode251 base/process/process_metrics.h:251: // GetSystemMemoryInfo. Total/free swap ...
5 years, 4 months ago (2015-08-10 18:49:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264683004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264683004/100001
5 years, 4 months ago (2015-08-10 18:50:47 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:100001)
5 years, 4 months ago (2015-08-10 20:40:15 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 20:41:08 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ae7209aeafdcb56f6761aeffe27f992fe2571a04
Cr-Commit-Position: refs/heads/master@{#342688}

Powered by Google App Engine
This is Rietveld 408576698