Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1264603002: Add test for referring function name for classes. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add test for referring function name for classes. R=mvstanton@chromium.org BUG=v8:4333 LOG=N Committed: https://crrev.com/67efca8be6756422dd0a7a05807e6cbe458a1c1f Cr-Commit-Position: refs/heads/master@{#29922}

Patch Set 1 #

Patch Set 2 : fixt typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M test/cctest/cctest.status View 1 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-func-name-inference.cc View 2 chunks +40 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1256193002 Patch 1

Messages

Total messages: 9 (3 generated)
Yang
5 years, 4 months ago (2015-07-29 09:36:57 UTC) #1
mvstanton
lgtm
5 years, 4 months ago (2015-07-29 09:38:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264603002/1
5 years, 4 months ago (2015-07-29 09:39:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264603002/20001
5 years, 4 months ago (2015-07-29 09:43:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-30 09:21:19 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 09:21:27 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/67efca8be6756422dd0a7a05807e6cbe458a1c1f
Cr-Commit-Position: refs/heads/master@{#29922}

Powered by Google App Engine
This is Rietveld 408576698