Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1264593003: Explicitly enable StrictMode VM policies. (Closed)

Created:
5 years, 4 months ago by Peter Wen
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly enable StrictMode VM policies. Since StrictMode currently interprets intents from ChromeLauncherActivity to view a file:// URI as exposing the URI, even though it will be handled by Chrome anyways, this causes false positive StrictMode violations. This change explicitly specifies all the StrictMode VM policies that we detect, and in so doing skip over the file URI exposed detection. In the future when Android fixes this StrictMode issue for multiprocess apps we can turn it back on. BUG=508282 Committed: https://crrev.com/fa3cc2102b6d90e695319247cc21a733d87d062d Cr-Commit-Position: refs/heads/master@{#340957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java View 1 chunk +17 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Wen
Hi David, This CL removes a StrictMode false positive by explicitly avoiding detecting that type ...
5 years, 4 months ago (2015-07-29 13:48:01 UTC) #2
David Trainor- moved to gerrit
lgtm
5 years, 4 months ago (2015-07-29 18:15:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264593003/1
5 years, 4 months ago (2015-07-29 18:55:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-29 19:48:34 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 19:50:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa3cc2102b6d90e695319247cc21a733d87d062d
Cr-Commit-Position: refs/heads/master@{#340957}

Powered by Google App Engine
This is Rietveld 408576698