Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1264583003: Revert of Add the 'Ask Google' option to the spelling submenu on Mac. (Closed)

Created:
5 years, 4 months ago by please use gerrit instead
Modified:
5 years, 4 months ago
Reviewers:
lazyboy, Julius
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add the 'Ask Google' option to the spelling submenu on Mac. (patchset #1 id:1 of https://codereview.chromium.org/1213133004/) Reason for revert: Reverting after discussion with Rachel. Original issue's description: > Add the 'Ask Google' option to the spelling submenu on Mac. > > For some reason the "Ask Google" option does not appear in the right- > click menu on Mac, even though it's present in the Settings menu. > > BUG=5102 > > Committed: https://crrev.com/8657b1d9e7c2040de20632fdf2ede3765cec4d9c > Cr-Commit-Position: refs/heads/master@{#336790} TBR=lazyboy@chromium.org,juliusa@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=5102 Committed: https://crrev.com/8f7a3cfb41e95259e9bc00deb90bd9dce144fb46 Cr-Commit-Position: refs/heads/master@{#341594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/browser/renderer_context_menu/spellchecker_submenu_observer_mac.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
please use gerrit instead
Created Revert of Add the 'Ask Google' option to the spelling submenu on Mac.
5 years, 4 months ago (2015-08-03 19:53:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264583003/1
5 years, 4 months ago (2015-08-03 19:54:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-03 19:55:56 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 19:56:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f7a3cfb41e95259e9bc00deb90bd9dce144fb46
Cr-Commit-Position: refs/heads/master@{#341594}

Powered by Google App Engine
This is Rietveld 408576698