Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1528)

Unified Diff: runtime/vm/object_arm64_test.cc

Issue 1264543002: Simplify constant pool usage in arm64 code generator (by removing extra argument (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intrinsifier_arm64.cc ('k') | runtime/vm/runtime_entry_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_arm64_test.cc
diff --git a/runtime/vm/object_arm64_test.cc b/runtime/vm/object_arm64_test.cc
index 44dec3bc06c11e4d7f69694849cffe65401fa376..9383cc2837b82142de610394c0a25ce19f1f836c 100644
--- a/runtime/vm/object_arm64_test.cc
+++ b/runtime/vm/object_arm64_test.cc
@@ -37,8 +37,9 @@ void GenerateEmbedStringInCode(Assembler* assembler, const char* str) {
String::ZoneHandle(String::New(str, Heap::kOld));
__ mov(SP, CSP);
__ TagAndPushPP(); // Save caller's pool pointer and load a new one here.
- __ LoadPoolPointer(PP);
- __ LoadObject(R0, string_object, PP);
+ __ LoadPoolPointer();
+ __ LoadObject(R0, string_object);
+ __ set_constant_pool_allowed(false);
__ PopAndUntagPP(); // Restore caller's pool pointer.
__ ret();
}
@@ -49,7 +50,7 @@ void GenerateEmbedStringInCode(Assembler* assembler, const char* str) {
void GenerateEmbedSmiInCode(Assembler* assembler, intptr_t value) {
const Smi& smi_object = Smi::ZoneHandle(Smi::New(value));
const int64_t val = reinterpret_cast<int64_t>(smi_object.raw());
- __ LoadImmediate(R0, val, kNoRegister);
+ __ LoadImmediate(R0, val);
__ ret();
}
« no previous file with comments | « runtime/vm/intrinsifier_arm64.cc ('k') | runtime/vm/runtime_entry_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698