Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: runtime/vm/instructions_arm64_test.cc

Issue 1264543002: Simplify constant pool usage in arm64 code generator (by removing extra argument (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/instructions_arm64_test.cc
diff --git a/runtime/vm/instructions_arm64_test.cc b/runtime/vm/instructions_arm64_test.cc
index 2d556fa2ab9571c0601784b7045f514272d7a5d4..c44b40bc9196df7d4b7320404121beba1e85a12c 100644
--- a/runtime/vm/instructions_arm64_test.cc
+++ b/runtime/vm/instructions_arm64_test.cc
@@ -16,6 +16,8 @@ namespace dart {
#define __ assembler->
ASSEMBLER_TEST_GENERATE(Call, assembler) {
+ // Code accessing pp is generated, but not executed. Uninitialized pp is OK.
+ __ set_constant_pool_allowed(true);
__ BranchLinkPatchable(&StubCode::InvokeDartCodeLabel());
__ ret();
}

Powered by Google App Engine
This is Rietveld 408576698