Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Side by Side Diff: runtime/vm/runtime_entry_arm64.cc

Issue 1264543002: Simplify constant pool usage in arm64 code generator (by removing extra argument (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/runtime_entry.h" 8 #include "vm/runtime_entry.h"
9 9
10 #include "vm/assembler.h" 10 #include "vm/assembler.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 ASSERT(argument_count == this->argument_count()); 42 ASSERT(argument_count == this->argument_count());
43 // Since we are entering C++ code, we must restore the C stack pointer from 43 // Since we are entering C++ code, we must restore the C stack pointer from
44 // the stack limit to an aligned value nearer to the top of the stack. 44 // the stack limit to an aligned value nearer to the top of the stack.
45 // We cache the Dart stack pointer and the stack limit in callee-saved 45 // We cache the Dart stack pointer and the stack limit in callee-saved
46 // registers, then align and call, restoring CSP and SP on return from the 46 // registers, then align and call, restoring CSP and SP on return from the
47 // call. 47 // call.
48 __ mov(R25, CSP); 48 __ mov(R25, CSP);
49 __ mov(R26, SP); 49 __ mov(R26, SP);
50 __ ReserveAlignedFrameSpace(0); 50 __ ReserveAlignedFrameSpace(0);
51 __ mov(CSP, SP); 51 __ mov(CSP, SP);
52 __ BranchLink(&label, kNoPP); 52 __ BranchLink(&label);
53 __ mov(SP, R26); 53 __ mov(SP, R26);
54 __ mov(CSP, R25); 54 __ mov(CSP, R25);
55 } else { 55 } else {
56 // Argument count is not checked here, but in the runtime entry for a more 56 // Argument count is not checked here, but in the runtime entry for a more
57 // informative error message. 57 // informative error message.
58 __ LoadExternalLabel(R5, &label, kNotPatchable, PP); 58 __ LoadExternalLabel(R5, &label);
59 __ LoadImmediate(R4, argument_count, kNoPP); 59 __ LoadImmediate(R4, argument_count);
60 __ BranchLink(&StubCode::CallToRuntimeLabel(), PP); 60 __ BranchLink(&StubCode::CallToRuntimeLabel());
61 } 61 }
62 } 62 }
63 63
64 } // namespace dart 64 } // namespace dart
65 65
66 #endif // defined TARGET_ARCH_ARM64 66 #endif // defined TARGET_ARCH_ARM64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698