Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3122)

Unified Diff: base/files/file.cc

Issue 126453004: Base: Rename File::error() to File::error_details() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/files/file.h ('k') | base/files/file_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/files/file.cc
diff --git a/base/files/file.cc b/base/files/file.cc
index 508103ac7d4e1ebac1d376565bd25f3b86abe258..478f9028443437c4a14480f11fe864132f02252b 100644
--- a/base/files/file.cc
+++ b/base/files/file.cc
@@ -20,7 +20,7 @@ File::Info::~Info() {
File::File()
: file_(kInvalidPlatformFileValue),
- error_(FILE_OK),
+ error_details_(FILE_OK),
created_(false),
async_(false) {
}
@@ -28,7 +28,7 @@ File::File()
#if !defined(OS_NACL)
File::File(const FilePath& name, uint32 flags)
: file_(kInvalidPlatformFileValue),
- error_(FILE_OK),
+ error_details_(FILE_OK),
created_(false),
async_(false) {
Initialize(name, flags);
@@ -37,14 +37,14 @@ File::File(const FilePath& name, uint32 flags)
File::File(PlatformFile platform_file)
: file_(platform_file),
- error_(FILE_OK),
+ error_details_(FILE_OK),
created_(false),
async_(false) {
}
File::File(RValue other)
: file_(other.object->TakePlatformFile()),
- error_(other.object->error()),
+ error_details_(other.object->error_details()),
created_(other.object->created()),
async_(other.object->async_) {
}
@@ -57,7 +57,7 @@ File& File::operator=(RValue other) {
if (this != other.object) {
Close();
SetPlatformFile(other.object->TakePlatformFile());
- error_ = other.object->error();
+ error_details_ = other.object->error_details();
created_ = other.object->created();
async_ = other.object->async_;
}
@@ -67,7 +67,7 @@ File& File::operator=(RValue other) {
#if !defined(OS_NACL)
void File::Initialize(const FilePath& name, uint32 flags) {
if (name.ReferencesParent()) {
- error_ = FILE_ERROR_ACCESS_DENIED;
+ error_details_ = FILE_ERROR_ACCESS_DENIED;
return;
}
InitializeUnsafe(name, flags);
« no previous file with comments | « base/files/file.h ('k') | base/files/file_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698