Add Resource Handler for creating Streams to forward to extensions

content/browser/streams/stream_handle_impl.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/streams/stream_handle_impl.h"
+
+#include "content/browser/streams/stream.h"
+#include "content/public/browser/browser_thread.h"
+
+namespace content {
+
+StreamHandleImpl::StreamHandleImpl(base::WeakPtr<Stream> stream)

[darin (slow to review), 2013/03/19 06:12:51]

nit: we normally pass WeakPtr using |const WeakPtr<...>&|

[Zachary Kuznia, 2013/03/19 06:59:35]

Done.

+    : stream_(stream),
+      url_(stream->url()),
+      stream_message_loop_(base::MessageLoopProxy::current()),
+      callback_message_loop_(NULL) {
+}
+
+StreamHandleImpl::~StreamHandleImpl() {
+  stream_message_loop_->PostTask(FROM_HERE,
+                                 base::Bind(&Stream::CloseHandle, stream_));
+}
+
+void StreamHandleImpl::SendCloseEvent() {

[darin (slow to review), 2013/03/19 06:12:51]

nit: Stream::CloseHandle and StreamHandle::SendCloseEvent sound very similar,
yet they are quite different.

There are really two states: 1) the StreamHandle gets destroyed, 2) the Stream
gets fully consumed (has no more data).

For #1, I think Stream::Close() makes sense.  For #2, maybe
StreamHandle::OnStreamConsumed().  Then, perhaps RegisterCloseCallback could be
renamed StreamHandle::NotifyWhenConsumed?

These are just naming suggestions.

[Zachary Kuznia, 2013/03/19 06:59:35]

Done.

+  base::AutoLock lock(callback_lock_);
+  stream_.reset();
+  if (!callback_.is_null()) {
+    CHECK(callback_message_loop_);
+    callback_message_loop_->PostTask(FROM_HERE, callback_);
+  }
+}
+
+const GURL& StreamHandleImpl::GetUrl() {
+  return url_;
+}
+
+void StreamHandleImpl::RegisterCloseCallback(const base::Closure& callback) {
+  base::AutoLock lock(callback_lock_);
+  if (stream_) {
+    callback_ = callback;
+    callback_message_loop_ = base::MessageLoopProxy::current();
+  } else {
+    // If the stream is NULL, the close event has already been sent.
+    base::MessageLoopProxy::current()->PostTask(FROM_HERE, callback);
+  }
+}
+
+}  // namespace content