[deoptimizer] Fix the frame size calculation for debugger-inspectable frame construction.

[deoptimizer] Fix the frame size calculation for debugger-inspectable frame construction.

The calculation now takes into account the size of the arguments object
if it is present in the optimized frame.

(Yang, many thanks for the awesome repro!)

BUG=chromium:514362
LOG=N
R=yangguo@chromium.org

Committed: https://crrev.com/156a155be37a32d4b9a14e31ef605df51bf0ab8a
Cr-Commit-Position: refs/heads/master@{#29973}

[Jarin, 2015-08-03 11:32:38]

Could you take a look, please?

[Yang, 2015-08-03 11:35:14]

LGTM with a comment.

https://codereview.chromium.org/1264483008/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://codereview.chromium.org/1264483008/diff/1/src/deoptimizer.cc#newcode160
src/deoptimizer.cc:160:
data->ArgumentsStackHeight(deoptimization_index)->value() * kPointerSize;
ComputeOutgoingArgumentSize() contains the same code. Can we somehow avoid
having this duplicate code?

[Jarin, 2015-08-03 11:48:23]

https://codereview.chromium.org/1264483008/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://codereview.chromium.org/1264483008/diff/1/src/deoptimizer.cc#newcode160
src/deoptimizer.cc:160:
data->ArgumentsStackHeight(deoptimization_index)->value() * kPointerSize;
On 2015/08/03 11:35:14, Yang wrote:
> ComputeOutgoingArgumentSize() contains the same code. Can we somehow avoid
> having this duplicate code?

Done.

[Yang, 2015-08-03 12:14:02]

On 2015/08/03 11:48:23, Jarin wrote:
> https://codereview.chromium.org/1264483008/diff/1/src/deoptimizer.cc
> File src/deoptimizer.cc (right):
> 
>
https://codereview.chromium.org/1264483008/diff/1/src/deoptimizer.cc#newcode160
> src/deoptimizer.cc:160:
> data->ArgumentsStackHeight(deoptimization_index)->value() * kPointerSize;
> On 2015/08/03 11:35:14, Yang wrote:
> > ComputeOutgoingArgumentSize() contains the same code. Can we somehow avoid
> > having this duplicate code?
> 
> Done.

lgtm

[Jarin, 2015-08-03 12:57:49]

The CQ bit was checked by jarin@chromium.org

[commit-bot: I haz the power, 2015-08-03 12:57:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1264483008/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1264483008/40001

[commit-bot: I haz the power, 2015-08-03 12:59:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-03 13:00:11]

Patchset 3 (id:??) landed as
https://crrev.com/156a155be37a32d4b9a14e31ef605df51bf0ab8a
Cr-Commit-Position: refs/heads/master@{#29973}