Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: Source/web/WebViewImpl.h

Issue 1264483002: PageOverlays: Remove PageOverlayList (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Move WebPageOverlay to PageOverlay Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebViewImpl.h
diff --git a/Source/web/WebViewImpl.h b/Source/web/WebViewImpl.h
index 53d58237c210e87e4ffd5ff28e193cb2fb1525ab..19d09e4d5e26e28e69ff2a2433e9d62ce2fac89f 100644
--- a/Source/web/WebViewImpl.h
+++ b/Source/web/WebViewImpl.h
@@ -55,7 +55,7 @@
#include "web/DragClientImpl.h"
#include "web/EditorClientImpl.h"
#include "web/MediaKeysClientImpl.h"
-#include "web/PageOverlayList.h"
+#include "web/PageOverlay.h"
dgozman 2015/07/30 10:17:31 Forward-declare it.
sergeyv 2015/07/30 11:42:37 Done.
#include "web/PageWidgetDelegate.h"
#include "web/SpellCheckerClientImpl.h"
#include "web/StorageClientImpl.h"
@@ -258,9 +258,7 @@ public:
void showContextMenu() override;
void extractSmartClipData(WebRect, WebString&, WebString&, WebRect&) override;
void hidePopups() override;
- void addPageOverlay(WebPageOverlay*, int /* zOrder */) override;
void setPageOverlayColor(WebColor) override;
- void removePageOverlay(WebPageOverlay*) override;
void transferActiveWheelFlingAnimation(const WebActiveWheelFlingParameters&) override;
bool endActiveFlingAnimation() override;
void setShowPaintRects(bool) override;
@@ -295,8 +293,6 @@ public:
WebColor backgroundColorOverride() const { return m_backgroundColorOverride; }
- PageOverlayList* pageOverlays() const { return m_pageOverlays.get(); }
-
void setOverlayLayer(GraphicsLayer*);
const WebPoint& lastMouseDownPoint() const
@@ -710,7 +706,7 @@ private:
OwnPtrWillBePersistent<InspectorOverlayImpl> m_inspectorOverlay;
OwnPtrWillBePersistent<DevToolsEmulator> m_devToolsEmulator;
- OwnPtr<PageOverlayList> m_pageOverlays;
+ OwnPtr<PageOverlay> m_pageColorOverlay;
// Whether the webview is rendering transparently.
bool m_isTransparent;
@@ -757,7 +753,6 @@ private:
FloatSize m_elasticOverscroll;
RefPtrWillBePersistent<EventListener> m_popupMouseWheelEventListener;
- OwnPtr<WebPageOverlay> m_pageColorOverlay;
};
DEFINE_TYPE_CASTS(WebViewImpl, WebWidget, widget, widget->isWebView(), widget.isWebView());

Powered by Google App Engine
This is Rietveld 408576698