Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1646)

Unified Diff: Source/web/WebViewImpl.h

Issue 1264483002: PageOverlays: Remove PageOverlayList (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebViewImpl.h
diff --git a/Source/web/WebViewImpl.h b/Source/web/WebViewImpl.h
index 504e22b9ef78e57c5c67752085393c0d8759934d..d2ef2d2914913bcef1908a958923d6f39b96ce23 100644
--- a/Source/web/WebViewImpl.h
+++ b/Source/web/WebViewImpl.h
@@ -55,7 +55,7 @@
#include "web/DragClientImpl.h"
#include "web/EditorClientImpl.h"
#include "web/MediaKeysClientImpl.h"
-#include "web/PageOverlayList.h"
+#include "web/PageOverlay.h"
#include "web/PageWidgetDelegate.h"
#include "web/SpellCheckerClientImpl.h"
#include "web/StorageClientImpl.h"
@@ -257,9 +257,9 @@ public:
void showContextMenu() override;
void extractSmartClipData(WebRect, WebString&, WebString&, WebRect&) override;
void hidePopups() override;
- void addPageOverlay(WebPageOverlay*, int /* zOrder */) override;
+ void addPageOverlay(WebPageOverlay*);
void setPageOverlayColor(WebColor) override;
- void removePageOverlay(WebPageOverlay*) override;
+ void removePageOverlay(WebPageOverlay*);
void transferActiveWheelFlingAnimation(const WebActiveWheelFlingParameters&) override;
bool endActiveFlingAnimation() override;
void setShowPaintRects(bool) override;
@@ -294,7 +294,7 @@ public:
WebColor backgroundColorOverride() const { return m_backgroundColorOverride; }
- PageOverlayList* pageOverlays() const { return m_pageOverlays.get(); }
+ PageOverlay* pageOverlay() const { return m_pageOverlay.get(); }
dgozman 2015/07/28 16:16:57 I think this should be |pageOverlayForTesting|.
sergeyv 2015/07/29 18:12:36 Now it's deleted
void setOverlayLayer(GraphicsLayer*);
@@ -709,7 +709,7 @@ private:
OwnPtrWillBePersistent<InspectorOverlayImpl> m_inspectorOverlay;
OwnPtr<DevToolsEmulator> m_devToolsEmulator;
- OwnPtr<PageOverlayList> m_pageOverlays;
+ OwnPtr<PageOverlay> m_pageOverlay;
// Whether the webview is rendering transparently.
bool m_isTransparent;

Powered by Google App Engine
This is Rietveld 408576698