mandoline sandbox: prewarm libraries before we raise the sandbox.

mandoline/app/desktop/linux_sandbox.cc

Index: mandoline/app/desktop/linux_sandbox.cc
diff --git a/mandoline/app/desktop/linux_sandbox.cc b/mandoline/app/desktop/linux_sandbox.cc
deleted file mode 100644
index 732a99e953a812f4300cc549f58f282b138f97d8..0000000000000000000000000000000000000000
--- a/mandoline/app/desktop/linux_sandbox.cc
+++ /dev/null
@@ -1,145 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "mandoline/app/desktop/linux_sandbox.h"
-
-#include <fcntl.h>
-#include <sys/syscall.h>
-
-#include "base/bind.h"
-#include "base/debug/leak_annotations.h"
-#include "base/posix/eintr_wrapper.h"
-#include "base/rand_util.h"
-#include "base/sys_info.h"
-#include "sandbox/linux/bpf_dsl/policy.h"
-#include "sandbox/linux/bpf_dsl/trap_registry.h"
-#include "sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.h"
-#include "sandbox/linux/seccomp-bpf-helpers/syscall_sets.h"
-#include "sandbox/linux/seccomp-bpf/sandbox_bpf.h"
-#include "sandbox/linux/services/credentials.h"
-#include "sandbox/linux/services/namespace_sandbox.h"
-#include "sandbox/linux/services/proc_util.h"
-
-using sandbox::syscall_broker::BrokerFilePermission;
-
-namespace mandoline {
-
-namespace {
-
-intptr_t SandboxSIGSYSHandler(const struct sandbox::arch_seccomp_data& args,
-                              void* aux) {
-  RAW_CHECK(aux);
-  const sandbox::syscall_broker::BrokerProcess* broker_process =
-      static_cast<const sandbox::syscall_broker::BrokerProcess*>(aux);
-  switch (args.nr) {
-    case __NR_access:
-      return broker_process->Access(reinterpret_cast<const char*>(args.args[0]),
-                                    static_cast<int>(args.args[1]));
-    case __NR_open:
-      return broker_process->Open(reinterpret_cast<const char*>(args.args[0]),
-                                  static_cast<int>(args.args[1]));
-    case __NR_faccessat:
-      if (static_cast<int>(args.args[0]) == AT_FDCWD) {
-        return broker_process->Access(
-            reinterpret_cast<const char*>(args.args[1]),
-            static_cast<int>(args.args[2]));
-      } else {
-        return -EPERM;
-      }
-    case __NR_openat:
-      // Allow using openat() as open().
-      if (static_cast<int>(args.args[0]) == AT_FDCWD) {
-        return broker_process->Open(reinterpret_cast<const char*>(args.args[1]),
-                                    static_cast<int>(args.args[2]));
-      } else {
-        return -EPERM;
-      }
-    default:
-      RAW_CHECK(false);
-      return -ENOSYS;
-  }
-}
-
-class SandboxPolicy : public sandbox::bpf_dsl::Policy {
- public:
-  explicit SandboxPolicy(sandbox::syscall_broker::BrokerProcess* broker_process)
-      : broker_process_(broker_process) {}
-  ~SandboxPolicy() override {}
-
-  // Overridden from sandbox::bpf_dsl::Policy:
-  sandbox::bpf_dsl::ResultExpr EvaluateSyscall(int sysno) const override {
-    // This policy is only advisory/for noticing FS access for the moment.
-    switch (sysno) {
-      case __NR_access:
-      case __NR_open:
-      case __NR_faccessat:
-      case __NR_openat:
-        return sandbox::bpf_dsl::Trap(SandboxSIGSYSHandler, broker_process_);
-    }
-
-    return sandbox::bpf_dsl::Allow();
-  }
-
- private:
-  // Not owned.
-  const sandbox::syscall_broker::BrokerProcess* broker_process_;
-  DISALLOW_COPY_AND_ASSIGN(SandboxPolicy);
-};
-
-}  // namespace
-
-LinuxSandbox::LinuxSandbox(const std::vector<BrokerFilePermission>& permissions)
-    : broker_(new sandbox::syscall_broker::BrokerProcess(EPERM, permissions)) {
-  broker_->Init(
-      base::Bind<bool (*)()>(&sandbox::Credentials::DropAllCapabilities));
-  policy_.reset(new SandboxPolicy(broker_.get()));
-}
-
-LinuxSandbox::~LinuxSandbox() {}
-
-// static
-std::vector<BrokerFilePermission> LinuxSandbox::GetPermissions() {
-  std::vector<BrokerFilePermission> permissions;
-  permissions.push_back(BrokerFilePermission::ReadOnly("/dev/urandom"));
-  permissions.push_back(BrokerFilePermission::ReadOnly("/etc/ld.so.cache"));
-  permissions.push_back(BrokerFilePermission::ReadOnlyRecursive("/lib/"));
-  permissions.push_back(BrokerFilePermission::ReadOnlyRecursive("/usr/lib/"));
-  return permissions;
-}
-
-void LinuxSandbox::Warmup() {
-  proc_fd_ = sandbox::ProcUtil::OpenProc();
-  warmed_up_ = true;
-}
-
-void LinuxSandbox::EngageNamespaceSandbox() {
-  CHECK(warmed_up_);
-  CHECK_EQ(1, getpid());
-  CHECK(sandbox::NamespaceSandbox::InNewPidNamespace());
-  CHECK(sandbox::Credentials::MoveToNewUserNS());
-  CHECK(sandbox::Credentials::DropFileSystemAccess(proc_fd_.get()));
-  CHECK(sandbox::Credentials::DropAllCapabilities(proc_fd_.get()));
-}
-
-void LinuxSandbox::EngageSeccompSandbox() {
-  CHECK(warmed_up_);
-  sandbox::SandboxBPF sandbox(policy_.release());
-  base::ScopedFD proc_fd(HANDLE_EINTR(
-      openat(proc_fd_.get(), ".", O_RDONLY | O_DIRECTORY | O_CLOEXEC)));
-  CHECK(proc_fd.is_valid());
-  sandbox.SetProcFd(proc_fd.Pass());
-  CHECK(
-      sandbox.StartSandbox(sandbox::SandboxBPF::SeccompLevel::SINGLE_THREADED))
-      << "Starting the process with a sandbox failed. Missing kernel support.";
-
-  // The Broker is now bound to this process and should only be destroyed when
-  // the process exits or is killed.
-  ANNOTATE_LEAKING_OBJECT_PTR(broker_.release());
-}
-
-void LinuxSandbox::Seal() {
-  proc_fd_.reset();
-}
-
-}  // namespace mandoline