Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: Source/core/workers/WorkerScriptLoader.cpp

Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start()) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addressed #7. Rebased Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/workers/WorkerScriptLoader.cpp
diff --git a/Source/core/workers/WorkerScriptLoader.cpp b/Source/core/workers/WorkerScriptLoader.cpp
index ec75c5e063dbc16bfbb74f746c39348d7aa1c038..7feac230f0e48f75f14683e4b22a7900b823c268 100644
--- a/Source/core/workers/WorkerScriptLoader.cpp
+++ b/Source/core/workers/WorkerScriptLoader.cpp
@@ -101,7 +101,8 @@ void WorkerScriptLoader::loadAsynchronously(ExecutionContext& executionContext,
resourceLoaderOptions.allowCredentials = AllowStoredCredentials;
m_needToCancel = true;
- m_threadableLoader = ThreadableLoader::create(executionContext, this, *request, options, resourceLoaderOptions);
+ m_threadableLoader = ThreadableLoader::create(executionContext, this, options, resourceLoaderOptions);
+ m_threadableLoader->start(*request);
if (m_failed)
notifyFinished();
// Do nothing here since notifyFinished() could delete |this|.

Powered by Google App Engine
This is Rietveld 408576698