third_party/WebKit/Source/modules/fetch/FetchManager.cpp - Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start())

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start()) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed pipes around non-variables in a comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp ('k') | third_party/WebKit/Source/web/AssociatedURLLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

index 6fe0bdeff7e53fce6cf27c6a9aa0c7d99f828a50..a638964119f86817df3e0da976e059a26859e4ad 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

+++ b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

@@ -611,9 +611,8 @@ void FetchManager::Loader::performHTTPFetch(bool corsFlag, bool corsPreflightFla

break;

}

InspectorInstrumentation::willStartFetch(executionContext(), this);

- m_loader = ThreadableLoader::create(*executionContext(), this, request, threadableLoaderOptions, resourceLoaderOptions);

- if (!m_loader)

- performNetworkError("Can't create ThreadableLoader");

+ m_loader = ThreadableLoader::create(*executionContext(), this, threadableLoaderOptions, resourceLoaderOptions);

+ m_loader->start(request);

}

// performDataFetch() is almost the same as performHTTPFetch(), except for:

@@ -646,9 +645,8 @@ void FetchManager::Loader::performDataFetch()

threadableLoaderOptions.crossOriginRequestPolicy = AllowCrossOriginRequests;