third_party/WebKit/Source/core/page/EventSourceTest.cpp - Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start())

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/EventSourceTest.cpp

Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start()) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed pipes around non-variables in a comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/EventSource.cpp ('k') | third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/EventSourceTest.cpp

diff --git a/third_party/WebKit/Source/core/page/EventSourceTest.cpp b/third_party/WebKit/Source/core/page/EventSourceTest.cpp

index 6ab1b8197d81e706e7b0116340f1cebdf7554c98..93f437efbf9db6594b4cb342c1b71fa5624aa651 100644

--- a/third_party/WebKit/Source/core/page/EventSourceTest.cpp

+++ b/third_party/WebKit/Source/core/page/EventSourceTest.cpp

@@ -14,6 +14,7 @@

#include "core/events/Event.h"

#include "core/events/EventListener.h"

#include "core/events/MessageEvent.h"

+#include "core/loader/MockThreadableLoader.h"

#include "core/page/EventSourceInit.h"

#include "core/testing/DummyPageHolder.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -67,11 +68,11 @@ protected:

, m_source(EventSource::create(&document(), "https://localhost/", EventSourceInit(), m_exceptionState))

{

source()->setStateForTest(EventSource::OPEN);

- source()->setRequestInFlightForTest(true);

+ source()->setThreadableLoaderForTest(MockThreadableLoader::create());

}

~EventSourceTest() override

{

- source()->setRequestInFlightForTest(false);

+ source()->setThreadableLoaderForTest(nullptr);

source()->close();

// We need this because there is