Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: third_party/WebKit/Source/core/page/EventSource.h

Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start()) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed pipes around non-variables in a comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/EventSource.h
diff --git a/third_party/WebKit/Source/core/page/EventSource.h b/third_party/WebKit/Source/core/page/EventSource.h
index 94651135958100f20ddb7efa2f44f869adeb5f2b..23eddfc73e39fb6940b87eb539bbd44a6f31b866 100644
--- a/third_party/WebKit/Source/core/page/EventSource.h
+++ b/third_party/WebKit/Source/core/page/EventSource.h
@@ -34,6 +34,7 @@
#include "core/dom/ActiveDOMObject.h"
#include "core/events/EventTarget.h"
+#include "core/loader/ThreadableLoader.h"
#include "core/loader/ThreadableLoaderClient.h"
#include "platform/Timer.h"
#include "platform/heap/Handle.h"
@@ -48,7 +49,6 @@ class ExceptionState;
class MessageEvent;
class ResourceResponse;
class TextResourceDecoder;
-class ThreadableLoader;
class CORE_EXPORT EventSource final : public RefCountedGarbageCollectedEventTargetWithInlineData<EventSource>, private ThreadableLoaderClient, public ActiveDOMObject {
DEFINE_WRAPPERTYPEINFO();
@@ -93,7 +93,7 @@ public:
DECLARE_VIRTUAL_TRACE();
void setStateForTest(State state) { m_state = state; }
- void setRequestInFlightForTest(bool b) { m_requestInFlight = b; }
+ void setThreadableLoaderForTest(PassRefPtr<ThreadableLoader> loader) { m_loader = loader; }
ThreadableLoaderClient* asThreadableLoaderClientForTest() { return this; }
unsigned long long reconnectDelayForTest() const { return m_reconnectDelay; }
@@ -126,7 +126,6 @@ private:
Timer<EventSource> m_connectTimer;
Vector<UChar> m_receiveBuf;
bool m_discardTrailingNewline;
- bool m_requestInFlight;
AtomicString m_eventName;
Vector<UChar> m_data;
« no previous file with comments | « third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp ('k') | third_party/WebKit/Source/core/page/EventSource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698