third_party/WebKit/Source/core/loader/ThreadableLoader.cpp - Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start())

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/ThreadableLoader.cpp

Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start()) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed pipes around non-variables in a comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/ThreadableLoader.h ('k') | third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/ThreadableLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/ThreadableLoader.cpp b/third_party/WebKit/Source/core/loader/ThreadableLoader.cpp

index ecbe493e1aa53666416b1d4ec0f4498d78c08a48..cf07e5cd0f00f89b3b20144ed5729c8794908d9b 100644

--- a/third_party/WebKit/Source/core/loader/ThreadableLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/ThreadableLoader.cpp

@@ -40,15 +40,15 @@

namespace blink {

-PassRefPtr<ThreadableLoader> ThreadableLoader::create(ExecutionContext& context, ThreadableLoaderClient* client, const ResourceRequest& request, const ThreadableLoaderOptions& options, const ResourceLoaderOptions& resourceLoaderOptions)

+PassRefPtr<ThreadableLoader> ThreadableLoader::create(ExecutionContext& context, ThreadableLoaderClient* client, const ThreadableLoaderOptions& options, const ResourceLoaderOptions& resourceLoaderOptions)

{

ASSERT(client);

if (context.isWorkerGlobalScope()) {

- return WorkerThreadableLoader::create(toWorkerGlobalScope(context), client, request, options, resourceLoaderOptions);

+ return WorkerThreadableLoader::create(toWorkerGlobalScope(context), client, options, resourceLoaderOptions);

}

- return DocumentThreadableLoader::create(toDocument(context), client, request, options, resourceLoaderOptions);

+ return DocumentThreadableLoader::create(toDocument(context), client, options, resourceLoaderOptions);

}

void ThreadableLoader::loadResourceSynchronously(ExecutionContext& context, const ResourceRequest& request, ThreadableLoaderClient& client, const ThreadableLoaderOptions& options, const ResourceLoaderOptions& resourceLoaderOptions)