third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h - Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start())

Unified Diff: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start()) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-async-xhr-post.html ('K') | « third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp ('k') | third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp » ('j') | third_party/WebKit/Source/core/loader/ThreadableLoader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

diff --git a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

index 7907c2e936d3c8e4eb51d06a5b43d95d30844f24..04a2a05a8d74f5499adb8a6eaab3cf557965fefd 100644

--- a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

+++ b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

@@ -57,9 +57,11 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, priv

USING_FAST_MALLOC(DocumentThreadableLoader);

public:

static void loadResourceSynchronously(Document&, const ResourceRequest&, ThreadableLoaderClient&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);

- static PassRefPtr<DocumentThreadableLoader> create(Document&, ThreadableLoaderClient*, const ResourceRequest&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);

+ static PassRefPtr<DocumentThreadableLoader> create(Document&, ThreadableLoaderClient*, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);

~DocumentThreadableLoader() override;

+ void start(const ResourceRequest&) override;

void overrideTimeout(unsigned long timeout) override;

// |this| may be dead after calling this method in async mode.

@@ -72,7 +74,7 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, priv

LoadAsynchronously

};

- DocumentThreadableLoader(Document&, ThreadableLoaderClient*, BlockingBehavior, const ResourceRequest&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);

+ DocumentThreadableLoader(Document&, ThreadableLoaderClient*, BlockingBehavior, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);

void clear();

@@ -200,7 +202,7 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, priv

const bool m_async;

// Holds the original request context (used for sanity checks).

- const WebURLRequest::RequestContext m_requestContext;

+ WebURLRequest::RequestContext m_requestContext;

// Holds the original request for fallback in case the Service Worker

// does not respond.

@@ -222,7 +224,7 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, priv

// because same-origin redirects are not counted here.

int m_corsRedirectLimit;

- const WebURLRequest::FetchRedirectMode m_redirectMode;

+ WebURLRequest::FetchRedirectMode m_redirectMode;

};

} // namespace blink