Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1233)

Unified Diff: Source/core/loader/DocumentThreadableLoader.h

Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start()) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/loader/DocumentThreadableLoader.h
diff --git a/Source/core/loader/DocumentThreadableLoader.h b/Source/core/loader/DocumentThreadableLoader.h
index b5b9d9d9d53c546e69326c67511603dbf2777e1c..66a2453c68e4bd79d628549945de558194bcef04 100644
--- a/Source/core/loader/DocumentThreadableLoader.h
+++ b/Source/core/loader/DocumentThreadableLoader.h
@@ -57,9 +57,11 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, priv
WTF_MAKE_FAST_ALLOCATED(DocumentThreadableLoader);
public:
static void loadResourceSynchronously(Document&, const ResourceRequest&, ThreadableLoaderClient&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);
- static PassRefPtr<DocumentThreadableLoader> create(Document&, ThreadableLoaderClient*, const ResourceRequest&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);
+ static PassRefPtr<DocumentThreadableLoader> create(Document&, ThreadableLoaderClient*, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);
~DocumentThreadableLoader() override;
+ void start(const ResourceRequest&) override;
+
void overrideTimeout(unsigned long timeout) override;
void cancel() override;
@@ -71,7 +73,7 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, priv
LoadAsynchronously
};
- DocumentThreadableLoader(Document&, ThreadableLoaderClient*, BlockingBehavior, const ResourceRequest&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);
+ DocumentThreadableLoader(Document&, ThreadableLoaderClient*, BlockingBehavior, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);
// ResourceClient
void notifyFinished(Resource*) override;
@@ -149,7 +151,7 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, priv
const bool m_async;
// Holds the original request context (used for sanity checks).
- const WebURLRequest::RequestContext m_requestContext;
+ WebURLRequest::RequestContext m_requestContext;
// Holds the original request for fallback in case the Service Worker
// does not respond.

Powered by Google App Engine
This is Rietveld 408576698