LayoutTests/http/tests/security/mixedContent/insecure-async-post-xhr-blocked.html - Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start())

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/security/mixedContent/insecure-async-post-xhr-blocked.html

Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start()) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed #7. Rebased Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-async-xhr-post.html » ('j') | Source/core/loader/ThreadableLoader.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="/js-test-resources/testharness.js"></script>

	3 <script src="/js-test-resources/testharnessreport.js"></script>

	4 <script>

	5 if (window.testRunner) {

	6 testRunner.overridePreference("WebKitAllowRunningInsecureContent", false);

	7 }

	8

	9 var test = async_test("Opens a HTTPS window that loads insecure data via XHR. W e should trigger a mixed content callback and block the load.");

	10

	11 window.addEventListener("message", test.step_func(function (e) {

	12 assert_equals(e.data, "DONE");

	13 test.done();

	14 }), false);

	15 window.open("http://127.0.0.1:8000/security/mixedContent/resources/frame-with-in secure-async-xhr-post.html");
	hiroshige 2015/08/11 09:54:42 The description says "Opens a HTTPS window" but he The description says "Opens a HTTPS window" but here we open HTTP window; should this be window.open("https://127.0.0.1:8443/...")? tyoshino (SeeGerritForStatus) 2016/01/29 12:36:52 Right! Fixed Show quoted text On 2015/08/11 09:54:42, hiroshige wrote: > The description says "Opens a HTTPS window" but here we open HTTP window; should > this be window.open("https://127.0.0.1:8443/...")? Right! Fixed tyoshino (SeeGerritForStatus) 2016/01/29 12:37:56 Oh, this reply had to be published before. Show quoted text On 2016/01/29 12:36:52, tyoshino wrote: > On 2015/08/11 09:54:42, hiroshige wrote: > > The description says "Opens a HTTPS window" but here we open HTTP window; > should > > this be window.open("https://127.0.0.1:8443/...")? > > Right! Fixed Oh, this reply had to be published before.
	16 </script>

OLD	NEW