Split the constructor of ThreadableLoader into two methods (ctor and start())

Source/core/loader/ThreadableLoader.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 107 matching lines @@
     class CORE_EXPORT ThreadableLoader : public RefCounted<ThreadableLoader> {
         WTF_MAKE_NONCOPYABLE(ThreadableLoader);
     public:
         // ThreadableLoaderOptions argument configures this ThreadableLoader's
         // behavior.
         //
         // ResourceLoaderOptions argument will be passed to the FetchRequest
         // that this ThreadableLoader creates. It can be altered e.g. when
         // redirect happens.
         static void loadResourceSynchronously(ExecutionContext&, const ResourceRequest&, ThreadableLoaderClient&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);
-        static PassRefPtr<ThreadableLoader> create(ExecutionContext&, ThreadableLoaderClient*, const ResourceRequest&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);
+        static PassRefPtr<ThreadableLoader> create(ExecutionContext&, ThreadableLoaderClient*, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);

[hiroshige, 2015/07/28 11:35:37]

From the CL description:
Then should we move the ThreadableLoaderClient* argument to start() to make
explcit that the client's callback is not called from the constructor?

[hiroshige, 2015/07/28 11:35:37]

What is the reason for moving ResourceRequest& argument to start()? Please
describe it in the CL description.

[tyoshino (SeeGerritForStatus), 2015/07/28 12:21:50]

ResourceRequest is not stored in a member variable in DocumentThreadableLoader.
Passing it on construction requires adding a new variable that is used only
between create() and start(). I wanted to avoid that.

[tyoshino (SeeGerritForStatus), 2015/07/28 12:21:51]

Ah, I see. It also works! Maybe we should move almost everything.

[tyoshino (SeeGerritForStatus), 2015/07/28 12:36:54]

Hmm, but this needs much work. Can I postpone it?

[tyoshino (SeeGerritForStatus), 2015/07/28 12:36:55]

Updated the CL description.

[hiroshige, 2015/07/30 12:07:21]

Yes.
Then please add a comment stating that ThreadableLoaderClient* methods are not
called in create(), but can be called synchronously in start().

[tyoshino (SeeGerritForStatus), 2015/07/31 08:00:42]

Done.

+
+        virtual void start(const ResourceRequest&) = 0;
 
         // A ThreadableLoader may have a timeout specified. It is possible, in some cases, for
         // the timeout to be overridden after the request is sent (for example, XMLHttpRequests
         // may override their timeout setting after sending).
         //
         // Set a new timeout relative to the time the request started, in milliseconds.
         virtual void overrideTimeout(unsigned long timeoutMilliseconds) = 0;
 
         virtual void cancel() = 0;
 
         virtual ~ThreadableLoader() { }
 
     protected:
         ThreadableLoader() { }
     };
 
 } // namespace blink
 
 #endif // ThreadableLoader_h