Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 126443005: Use TreeScope::completeURL and baseURL instead of the Document versions (Closed)

Created:
6 years, 11 months ago by adamk
Modified:
6 years, 11 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, rwlbuis, krit, bemjb+rendering_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, jchaffraix+rendering, Inactive, sof, zoltan1, philipj_slow, feature-media-reviews_chromium.org, darktears, Nate Chapin, gavinp+prerender_chromium.org, leviw+renderwatch, f(malita), groby+blinkspell_chromium.org, Stephen Chennney
Visibility:
Public.

Description

Use TreeScope::completeURL and baseURL instead of the Document versions No change in behavior, as ShadowRoot::baseURL still delegates to its Document. BUG=311682 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165098

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased again, passes tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -71 lines) Patch
M Source/core/css/CSSCursorImageValue.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSParserMode.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSParserMode.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/FontBuilder.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolverState.h View 3 chunks +6 lines, -3 lines 0 comments Download
M Source/core/css/resolver/StyleResolverState.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ProcessingInstruction.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/VisitedLinkState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLAnchorElement.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLAppletElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLBodyElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFrameElementBase.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLHtmlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLKeygenElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLScriptElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTablePartElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLVideoElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/LinkResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/ImageLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PageSerializer.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/PrintContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/HitTestResult.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/shapes/ShapeInfo.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceUriElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGImageLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGURIReference.h View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
adamk
6 years, 11 months ago (2014-01-14 19:26:16 UTC) #1
abarth-chromium
LGTM
6 years, 11 months ago (2014-01-14 19:34:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/126443005/60001
6 years, 11 months ago (2014-01-14 19:50:46 UTC) #3
adamk
6 years, 11 months ago (2014-01-14 23:13:06 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as r165098 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698