Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1519)

Unified Diff: test/win/linker-flags/pdb-output.gyp

Issue 126443004: win ninja: include .pdb in linker outputs (Closed) Base URL: http://gyp.googlecode.com/svn/trunk
Patch Set: update comment Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/win/gyptest-link-pdb-output.py ('k') | test/win/linker-flags/program-database.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/win/linker-flags/pdb-output.gyp
diff --git a/test/win/linker-flags/program-database.gyp b/test/win/linker-flags/pdb-output.gyp
similarity index 55%
copy from test/win/linker-flags/program-database.gyp
copy to test/win/linker-flags/pdb-output.gyp
index b822a8be40e16b3372585a0c3b5a7e8d75b3183d..21d3cd76f3e83b318e3b2f032f2cf9432402b5ab 100644
--- a/test/win/linker-flags/program-database.gyp
+++ b/test/win/linker-flags/pdb-output.gyp
@@ -1,13 +1,11 @@
-# Copyright (c) 2012 Google Inc. All rights reserved.
+# Copyright (c) 2014 Google Inc. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
{
'targets': [
- # Verify that 'ProgramDataBase' option correctly makes it to LINK step in Ninja
{
- # Verify that VC macros and windows paths work correctly
- 'target_name': 'test_pdb_outdir',
+ 'target_name': 'test_pdb_output_exe',
'type': 'executable',
'sources': ['hello.cc'],
'msvs_settings': {
@@ -16,14 +14,13 @@
},
'VCLinkerTool': {
'GenerateDebugInformation': 'true',
- 'ProgramDatabaseFile': '$(OutDir)\\name_outdir.pdb',
+ 'ProgramDatabaseFile': 'output_exe.pdb',
},
},
},
{
- # Verify that GYP macros and POSIX paths work correctly
- 'target_name': 'test_pdb_proddir',
- 'type': 'executable',
+ 'target_name': 'test_pdb_output_dll',
+ 'type': 'shared_library',
'sources': ['hello.cc'],
'msvs_settings': {
'VCCLCompilerTool': {
@@ -31,7 +28,7 @@
},
'VCLinkerTool': {
'GenerateDebugInformation': 'true',
- 'ProgramDatabaseFile': '<(PRODUCT_DIR)/name_proddir.pdb',
+ 'ProgramDatabaseFile': 'output_dll.pdb',
},
},
},
« no previous file with comments | « test/win/gyptest-link-pdb-output.py ('k') | test/win/linker-flags/program-database.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698