Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 1264423003: FPDF_Creator can only create file through embedder-supplied callback. (Closed)

Created:
5 years, 4 months ago by Tom Sepez
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

FPDF_Creator can only create file through embedder-supplied callback. Hence, some of the routines taking filename strings are unused. This, in turn allows us to get rid of some other fopen-ishy looking things inside the library.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -70 lines) Patch
M core/include/fpdfapi/fpdf_serial.h View 1 chunk +1 line, -8 lines 0 comments Download
M core/include/fxcrt/fx_basic.h View 1 chunk +0 lines, -6 lines 0 comments Download
M core/include/fxcrt/fx_stream.h View 1 chunk +0 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M core/src/fxcrt/fx_basic_buffer.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
M core/src/fxcrt/fx_extension.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, for review. Nothing but red blocks :).
5 years, 4 months ago (2015-08-04 22:58:01 UTC) #2
Lei Zhang
lgtm
5 years, 4 months ago (2015-08-04 23:10:00 UTC) #3
Tom Sepez
5 years, 4 months ago (2015-08-05 17:18:42 UTC) #4
Somehow the bug failed to auto update with the commit info:
5cd398545141226f082b2f757f23c73303058a83

Powered by Google App Engine
This is Rietveld 408576698