Issue 1264423003: FPDF_Creator can only create file through embedder-supplied callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1264423003: FPDF_Creator can only create file through embedder-supplied callback. (Closed)

Created:
5 years, 4 months ago by Tom Sepez

Modified:
5 years, 4 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

FPDF_Creator can only create file through embedder-supplied callback. Hence, some of the routines taking filename strings are unused. This, in turn allows us to get rid of some other fopen-ishy looking things inside the library.

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -70 lines)			Patch
M	core/include/fpdfapi/fpdf_serial.h	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	core/include/fxcrt/fx_basic.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	core/include/fxcrt/fx_stream.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	core/src/fxcrt/fx_basic_buffer.cpp	View	1 chunk	+0 lines, -28 lines	0 comments	Download
M	core/src/fxcrt/fx_extension.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Tom Sepez

5 years, 4 months ago (2015-08-05 17:18:42 UTC) #4

Somehow the bug failed to auto update with the commit info:
5cd398545141226f082b2f757f23c73303058a83

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages