Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 126433003: Allow Desktop Capture API from incognito tabs. (Closed)

Created:
6 years, 11 months ago by Sergey Ulanov
Modified:
6 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Allow Desktop Capture API from incognito tabs. Previously Desktop Capture API allowed requests only from non-incognitor tabs. The API might be useful in incognito tabs in some scenarios. R=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sergey Ulanov
6 years, 11 months ago (2014-01-07 22:27:00 UTC) #1
Sergey Ulanov
+vrk
6 years, 11 months ago (2014-01-07 22:28:07 UTC) #2
Jói
LGTM
6 years, 11 months ago (2014-01-08 10:13:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/126433003/1
6 years, 11 months ago (2014-01-08 19:45:18 UTC) #4
Sergey Ulanov
6 years, 11 months ago (2014-01-09 00:19:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r243706 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698