bluetooth: Return specific message if Bluetooth Adapter is off

content/browser/bluetooth/bluetooth_dispatcher_host.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // NETWORK_ERROR Note:
 // When a device can't be found in the BluetoothAdapter, that generally
 // indicates that it's gone out of range. We reject with a NetworkError in that
 // case.
 // https://webbluetoothchrome.github.io/web-bluetooth/#dom-bluetoothdevice-connectgatt
 
@@ skipping 31 matching lines @@
   MAX_ERROR,
 };
 
 enum class UMARequestDeviceOutcome {
   SUCCESS = 0,
   NO_BLUETOOTH_ADAPTER = 1,
   NO_RENDER_FRAME = 2,
   DISCOVERY_START_FAILED = 3,
   DISCOVERY_STOP_FAILED = 4,
   NO_MATCHING_DEVICES_FOUND = 5,
+  BLUETOOTH_ADAPTER_NOT_PRESENT = 6,
+  BLUETOOTH_ADAPTER_OFF = 7,
   // NOTE: Add new requestDevice() outcomes immediately above this line. Make
   // sure to update the enum list in
   // tools/metrics/histogram/histograms.xml accordingly.
   COUNT
 };
 
 void RecordRequestDeviceOutcome(UMARequestDeviceOutcome outcome) {
   UMA_HISTOGRAM_ENUMERATION("Bluetooth.RequestDevice.Outcome",
                             static_cast<int>(outcome),
                             static_cast<int>(UMARequestDeviceOutcome::COUNT));
@@ skipping 227 matching lines @@
              .insert(std::make_pair(
                  std::make_pair(thread_id, request_id),
                  RequestDeviceSession(filters, optional_services)))
              .second) {
       LOG(ERROR) << "2 requestDevice() calls with the same thread_id ("
                  << thread_id << ") and request_id (" << request_id
                  << ") shouldn't arrive at the same BluetoothDispatcherHost.";
       bad_message::ReceivedBadMessage(
           this, bad_message::BDH_DUPLICATE_REQUEST_DEVICE_ID);
     }
+    if (!adapter_->IsPresent()) {
+      VLOG(1) << "Bluetooth Adapter not present. Can't serve requestDevice.";
+      RecordRequestDeviceOutcome(
+          UMARequestDeviceOutcome::BLUETOOTH_ADAPTER_NOT_PRESENT);
+      Send(new BluetoothMsg_RequestDeviceError(

[Jeffrey Yasskin, 2015/08/05 17:13:14]

Every Send needs to be matched to a request_device_sessions_.erase() call, or
come before the .insert().

[ortuno, 2015/08/05 18:01:53]

Done.

+          thread_id, request_id, WebBluetoothError::NoBluetoothAdapter));
+      return;
+    }
+    if (!adapter_->IsPowered()) {

[Jeffrey Yasskin, 2015/08/05 17:13:13]

This one isn't going to happen once we have the real dialog wired up. The dialog
will present a message asking the user to turn on the adapter, and if the user
chooses not to, they'll cancel the dialog. That should look to the code the same
as if they cancelled for any other reason.

At most, I think we should have a TODO here, to wire IsPowered() and
BluetoothAdapter::Observer::PoweredChanged to the dialog.

[ortuno, 2015/08/05 18:01:53]

True. But the dialog is gonna take a couple of releases to get wired up on all
platforms so I still think this log/histogram/message is useful. I'll add a TODO
for wiring it up to the dialog though.

Also this just made me realize that we don't handle the case where a user turns
off bluetooth midway. So for example if you connect to a device turn off
bluetooth and then call getPrimaryService nothing happens, no errors, no logs,
nothing.

+      VLOG(1) << "Bluetooth Adapter is not powered. Can't serve requestDevice.";
+      RecordRequestDeviceOutcome(
+          UMARequestDeviceOutcome::BLUETOOTH_ADAPTER_OFF);
+      Send(new BluetoothMsg_RequestDeviceError(
+          thread_id, request_id, WebBluetoothError::BluetoothAdapterOff));
+      return;
+    }
     adapter_->StartDiscoverySessionWithFilter(
         ComputeScanFilter(filters),
         base::Bind(&BluetoothDispatcherHost::OnDiscoverySessionStarted,
                    weak_ptr_factory_.GetWeakPtr(), thread_id, request_id),
         base::Bind(&BluetoothDispatcherHost::OnDiscoverySessionStartedError,
                    weak_ptr_factory_.GetWeakPtr(), thread_id, request_id));
   } else {
     DLOG(WARNING) << "No BluetoothAdapter. Can't serve requestDevice.";
     RecordRequestDeviceOutcome(UMARequestDeviceOutcome::NO_BLUETOOTH_ADAPTER);
     Send(new BluetoothMsg_RequestDeviceError(
@@ skipping 394 matching lines @@
 
 void BluetoothDispatcherHost::OnWriteValueFailed(
     int thread_id,
     int request_id,
     device::BluetoothGattService::GattErrorCode error_code) {
   Send(new BluetoothMsg_WriteCharacteristicValueError(
       thread_id, request_id, TranslateGATTError(error_code)));
 }
 
 }  // namespace content