Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: pkg/compiler/lib/src/js_emitter/native_generator.dart

Issue 1264303002: dart2js: fix a few TODOs in the startup emitter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Emit affinity tag only once. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/native_generator.dart
diff --git a/pkg/compiler/lib/src/js_emitter/native_generator.dart b/pkg/compiler/lib/src/js_emitter/native_generator.dart
index 9a4145c5a9b638919264b81d092a5985e2b0b3d6..fd15d8a0a21cbbfdbd3258e1561257da55692b70 100644
--- a/pkg/compiler/lib/src/js_emitter/native_generator.dart
+++ b/pkg/compiler/lib/src/js_emitter/native_generator.dart
@@ -17,7 +17,7 @@ class NativeGenerator {
static jsAst.Statement generateIsolateAffinityTagInitialization(
JavaScriptBackend backend,
jsAst.Expression generateEmbeddedGlobalAccess(String global),
- jsAst.Expression convertToFastObject) {
+ jsAst.Expression internStringFunction) {
assert(backend.needToInitializeIsolateAffinityTag);
jsAst.Expression getIsolateTagAccess =
@@ -29,13 +29,7 @@ class NativeGenerator {
return js.statement('''
!function() {
- // On V8, the 'intern' function converts a string to a symbol, which
- // makes property access much faster.
- function intern(s) {
- var o = {};
- o[s] = 1;
- return Object.keys(#convertToFastObject(o))[0];
- }
+ var intern = #internStringFunction;
#getIsolateTag = function(name) {
return intern("___dart_" + name + #isolateTag);
@@ -63,7 +57,7 @@ class NativeGenerator {
}();
''',
{'initializeDispatchProperty': backend.needToInitializeDispatchProperty,
- 'convertToFastObject': convertToFastObject,
+ 'internStringFunction': internStringFunction,
'getIsolateTag': getIsolateTagAccess,
'isolateTag': isolateTagAccess,
'dispatchPropertyName': dispatchPropertyNameAccess});

Powered by Google App Engine
This is Rietveld 408576698