pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart - Issue 1264303002: dart2js: fix a few TODOs in the startup emitter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart

Issue 1264303002: dart2js: fix a few TODOs in the startup emitter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Emit affinity tag only once. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart b/pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart

index ee7030ee960a7e547cb71af2b26ac6991f25ef57..b97a47ea2c2e957002e71213e8fb5b54a510ca38 100644

--- a/pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart

@@ -235,7 +235,7 @@ class ModelEmitter {

NativeGenerator.generateIsolateAffinityTagInitialization(

backend,

generateEmbeddedGlobalAccess,

- // TODO(floitsch): convertToFastObject.

+ // TODO(floitsch): internStringFunction.

js.js("(function(x) { return x; })", []));

} else {

nativeIsolateAffinityTagInitialization = js.js.statement(";");