Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1264283004: Revert of Use new API everywhere for GrDefaultGeoProcFactory (Closed)

Created:
5 years, 4 months ago by joshualitt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@lccleanup2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Use new API everywhere for GrDefaultGeoProcFactory (patchset #5 id:80001 of https://codereview.chromium.org/1261083003/) Reason for revert: breaking things Original issue's description: > Use new API everywhere for GrDefaultGeoProcFactory > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/801823b3d825d96baadeb9077c5ed1a8ada05cf2 TBR=robertphillips@google.com,bsalomon@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/e494a58de341daf08ae23007694a4f6ed4d9cd06

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -182 lines) Patch
M gm/convexpolyeffect.cpp View 4 chunks +5 lines, -7 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 2 chunks +18 lines, -24 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 chunk +12 lines, -12 lines 0 comments Download
M src/gpu/GrAALinearizingConvexPathRenderer.cpp View 2 chunks +18 lines, -24 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 3 chunks +27 lines, -25 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.h View 2 chunks +10 lines, -1 line 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 2 chunks +25 lines, -11 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 chunk +8 lines, -13 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 2 chunks +15 lines, -22 lines 0 comments Download
M src/gpu/GrRectBatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 1 chunk +5 lines, -18 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 2 chunks +22 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
joshualitt
Created Revert of Use new API everywhere for GrDefaultGeoProcFactory
5 years, 4 months ago (2015-08-03 16:31:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264283004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264283004/1
5 years, 4 months ago (2015-08-03 16:32:29 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 16:32:38 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e494a58de341daf08ae23007694a4f6ed4d9cd06

Powered by Google App Engine
This is Rietveld 408576698