Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1264283002: Add abliity to set textblob cache budget to GrContext (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add abliity to set textblob cache budget to GrContext BUG=skia: Committed: https://skia.googlesource.com/skia/+/17d833b05b1554fd1c54144b4bd2f4f23946b7b8

Patch Set 1 #

Total comments: 1

Patch Set 2 : move to GrTest #

Total comments: 1

Patch Set 3 : add check purge #

Patch Set 4 : tweaks #

Patch Set 5 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -29 lines) Patch
M include/gpu/GrContext.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M src/gpu/GrTextBlobCache.h View 1 2 3 4 3 chunks +40 lines, -29 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
joshualitt
ptal
5 years, 4 months ago (2015-08-03 15:17:37 UTC) #3
bsalomon
https://codereview.chromium.org/1264283002/diff/1/include/gpu/GrContext.h File include/gpu/GrContext.h (right): https://codereview.chromium.org/1264283002/diff/1/include/gpu/GrContext.h#newcode145 include/gpu/GrContext.h:145: void setTextBlobCacheLimit(size_t bytes); Is this just needed for testing? ...
5 years, 4 months ago (2015-08-03 15:28:31 UTC) #4
joshualitt
On 2015/08/03 15:28:31, bsalomon wrote: > https://codereview.chromium.org/1264283002/diff/1/include/gpu/GrContext.h > File include/gpu/GrContext.h (right): > > https://codereview.chromium.org/1264283002/diff/1/include/gpu/GrContext.h#newcode145 > ...
5 years, 4 months ago (2015-08-03 15:33:53 UTC) #5
bsalomon
question, otherwise lgtm https://codereview.chromium.org/1264283002/diff/20001/src/gpu/GrTextBlobCache.h File src/gpu/GrTextBlobCache.h (right): https://codereview.chromium.org/1264283002/diff/20001/src/gpu/GrTextBlobCache.h#newcode134 src/gpu/GrTextBlobCache.h:134: void setBudget(size_t budget) { fBudget = ...
5 years, 4 months ago (2015-08-03 15:40:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264283002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264283002/80001
5 years, 4 months ago (2015-08-03 17:10:56 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 17:17:47 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/17d833b05b1554fd1c54144b4bd2f4f23946b7b8

Powered by Google App Engine
This is Rietveld 408576698