Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 12642011: Allow inlining of functions containing array literals. (Closed)

Created:
7 years, 9 months ago by Michael Starzinger
Modified:
7 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Allow inlining of functions containing array literals. R=jkummerow@chromium.org BUG=v8:1322 TEST=mjsunit/compiler/inline-literals Committed: http://code.google.com/p/v8/source/detail?r=13947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M src/ast.cc View 4 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
7 years, 9 months ago (2013-03-14 14:33:20 UTC) #1
Jakob Kummerow
lgtm
7 years, 9 months ago (2013-03-14 15:01:30 UTC) #2
Michael Starzinger
Committed patchset #1 manually as r13947 (presubmit successful).
7 years, 9 months ago (2013-03-14 15:15:43 UTC) #3
Sven Panne
7 years, 9 months ago (2013-03-18 08:21:47 UTC) #4
Message was sent while issue was closed.
This regresses SunSpider's MathSpectralNorm quite visibly, one should have a
look at that...

Powered by Google App Engine
This is Rietveld 408576698