Implement on demand quad rasterization for PicturePiles.

content/common/cc_messages.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/cc_messages.h"
 
 #include "cc/output/compositor_frame.h"
 #include "content/public/common/common_param_traits.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebData.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebFilterOperations.h"
@@ skipping 302 matching lines @@
     switch (quad->material) {
       case cc::DrawQuad::CHECKERBOARD:
         WriteParam(m, *cc::CheckerboardDrawQuad::MaterialCast(quad));
         break;
       case cc::DrawQuad::DEBUG_BORDER:
         WriteParam(m, *cc::DebugBorderDrawQuad::MaterialCast(quad));
         break;
       case cc::DrawQuad::IO_SURFACE_CONTENT:
         WriteParam(m, *cc::IOSurfaceDrawQuad::MaterialCast(quad));
         break;
+      case cc::DrawQuad::PICTURE_CONTENT:
+        NOTIMPLEMENTED();

[piman, 2013/03/26 17:19:30]

nit: NOTREACHED() or DCHECK.
Not writing anything will confuse the reader (it expects the right number of
quads), so make sure to assert on the writer side so that this can be tracked at
the origin.

[danakj, 2013/03/26 17:28:52]

Oh, I had requested this, because NOTREACHED() will also randomly DCHECK if we
turn on implside painting. Didn't think about the number of quads. :/ I'll file
a bug.

[Leandro Graciá Gil, 2013/03/26 18:05:02]

Ok, in that case I'll change these back to NOTREACHED().

+        break;
       case cc::DrawQuad::TEXTURE_CONTENT:
         WriteParam(m, *cc::TextureDrawQuad::MaterialCast(quad));
         break;
       case cc::DrawQuad::RENDER_PASS:
         WriteParam(m, *cc::RenderPassDrawQuad::MaterialCast(quad));
         break;
       case cc::DrawQuad::SOLID_COLOR:
         WriteParam(m, *cc::SolidColorDrawQuad::MaterialCast(quad));
         break;
       case cc::DrawQuad::TILED_CONTENT:
@@ skipping 94 matching lines @@
     switch (material) {
       case cc::DrawQuad::CHECKERBOARD:
         draw_quad = ReadDrawQuad<cc::CheckerboardDrawQuad>(m, iter);
         break;
       case cc::DrawQuad::DEBUG_BORDER:
         draw_quad = ReadDrawQuad<cc::DebugBorderDrawQuad>(m, iter);
         break;
       case cc::DrawQuad::IO_SURFACE_CONTENT:
         draw_quad = ReadDrawQuad<cc::IOSurfaceDrawQuad>(m, iter);
         break;
+      case cc::DrawQuad::PICTURE_CONTENT:
+        NOTIMPLEMENTED();
+        return false;
       case cc::DrawQuad::TEXTURE_CONTENT:
         draw_quad = ReadDrawQuad<cc::TextureDrawQuad>(m, iter);
         break;
       case cc::DrawQuad::RENDER_PASS:
         draw_quad = ReadDrawQuad<cc::RenderPassDrawQuad>(m, iter);
         break;
       case cc::DrawQuad::SOLID_COLOR:
         draw_quad = ReadDrawQuad<cc::SolidColorDrawQuad>(m, iter);
         break;
       case cc::DrawQuad::TILED_CONTENT:
@@ skipping 59 matching lines @@
     switch (quad->material) {
       case cc::DrawQuad::CHECKERBOARD:
         LogParam(*cc::CheckerboardDrawQuad::MaterialCast(quad), l);
         break;
       case cc::DrawQuad::DEBUG_BORDER:
         LogParam(*cc::DebugBorderDrawQuad::MaterialCast(quad), l);
         break;
       case cc::DrawQuad::IO_SURFACE_CONTENT:
         LogParam(*cc::IOSurfaceDrawQuad::MaterialCast(quad), l);
         break;
+      case cc::DrawQuad::PICTURE_CONTENT:
+        NOTIMPLEMENTED();
+        break;
       case cc::DrawQuad::TEXTURE_CONTENT:
         LogParam(*cc::TextureDrawQuad::MaterialCast(quad), l);
         break;
       case cc::DrawQuad::RENDER_PASS:
         LogParam(*cc::RenderPassDrawQuad::MaterialCast(quad), l);
         break;
       case cc::DrawQuad::SOLID_COLOR:
         LogParam(*cc::SolidColorDrawQuad::MaterialCast(quad), l);
         break;
       case cc::DrawQuad::TILED_CONTENT:
@@ skipping 174 matching lines @@
   l->append(", [");
   for (size_t i = 0; i < p.render_pass_list.size(); ++i) {
     if (i)
       l->append(", ");
     LogParam(*p.render_pass_list[i], l);
   }
   l->append("])");
 }
 
 }  // namespace IPC