Implement on demand quad rasterization for PicturePiles.

cc/trees/layer_tree_host_pixeltest_on_demand_raster.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "cc/layers/append_quads_data.h"
+#include "cc/layers/content_layer_client.h"
+#include "cc/layers/picture_layer.h"
+#include "cc/layers/picture_layer_impl.h"
+#include "cc/quads/draw_quad.h"
+#include "cc/test/layer_tree_pixel_test.h"
+#include "cc/test/mock_quad_culler.h"
+#include "cc/trees/layer_tree_impl.h"
+#include "third_party/skia/include/core/SkCanvas.h"
+#include "third_party/skia/include/core/SkColor.h"
+#include "ui/gfx/rect.h"
+#include "ui/gfx/rect_f.h"
+
+#if !defined(OS_ANDROID)
+
+namespace cc {
+namespace {
+
+class LayerTreeHostOnDemandRasterPixelTest : public LayerTreePixelTest {
+ public:
+  LayerTreeHostOnDemandRasterPixelTest() {
+    m_settings.implSidePainting = true;

[danakj, 2013/03/21 02:34:42]

This will have to go in an override of InitializeSettings() after rebase

[Leandro Graciá Gil, 2013/03/21 16:42:48]

Done.

+  }
+
+  virtual void beginCommitOnThread(LayerTreeHostImpl* impl) OVERRIDE {
+    // Not enough memory available. Enforce on-demand rasterization.
+    impl->SetManagedMemoryPolicy(
+        ManagedMemoryPolicy(1, ManagedMemoryPolicy::CUTOFF_ALLOW_EVERYTHING,
+                            1, ManagedMemoryPolicy::CUTOFF_ALLOW_NOTHING));
+  }
+
+  virtual void swapBuffersOnThread(LayerTreeHostImpl* host_impl,
+                                   bool result) OVERRIDE {
+    // Find the PictureLayerImpl ask it to append quads to check their material.
+    // The PictureLayerImpl is assumed to be the first child of the root layer
+    // in the active tree.
+    PictureLayerImpl* picture_layer = static_cast<PictureLayerImpl*>(
+        host_impl->active_tree()->root_layer()->child_at(0));
+
+    QuadList quads;
+    SharedQuadStateList shared_states;
+    MockQuadCuller quad_culler(quads, shared_states);
+
+    AppendQuadsData data;
+    picture_layer->AppendQuads(&quad_culler, &data);
+
+    for (size_t i = 0; i < quads.size(); ++i)
+      EXPECT_EQ(quads[i]->material, DrawQuad::PICTURE_CONTENT);
+
+    // Triggers pixel readback and ends the test.
+    LayerTreePixelTest::swapBuffersOnThread(host_impl, result);
+  }
+};
+
+class BlueYellowLayerClient : public ContentLayerClient {
+ public:
+  BlueYellowLayerClient(const gfx::Rect& rect) : rect_(rect) { }

[danakj, 2013/03/21 02:34:42]

by value

[Leandro Graciá Gil, 2013/03/21 03:35:50]

Why? As we assign the const ref argument to a gfx::Rect object and not to a
const gfx::Rect& reference we are still copying the value. If we remove the
const ref from the argument we will unnecessarily create a temporary object and
trigger the copy constructor and destructor of gfx::Rect in the process. Plus,
it will take more stack space to perform the call (the full rect object vs
internally a pointer). Please correct me if I'm wrong.

[danakj, 2013/03/21 04:33:39]

Same comment here re gfx:: types.

[Leandro Graciá Gil, 2013/03/21 16:42:48]

Done.

+
+  virtual void PaintContents(SkCanvas* canvas,
+                             gfx::Rect clip,
+                             gfx::RectF* opaque) OVERRIDE {
+    *opaque = gfx::RectF(rect_.width(), rect_.height());
+
+    // Skia uses BGRA ordering rather than RGBA. As the results will be later
+    // compared with a RGBA image, swap the red and blue components here.
+    SkPaint paint;
+    paint.setColor(SwapRB(SK_ColorBLUE));
+    canvas->drawRect(SkRect::MakeWH(rect_.width() / 2, rect_.height()), paint);
+
+    paint.setColor(SwapRB(SK_ColorYELLOW));
+    canvas->drawRect(
+        SkRect::MakeXYWH(rect_.width() / 2, 0,
+                         rect_.width() / 2, rect_.height()),
+        paint);
+  }
+
+  static SkColor SwapRB(SkColor color) {
+    return SkColorSetARGB(
+        SkColorGetA(color),
+        SkColorGetB(color),
+        SkColorGetG(color),
+        SkColorGetR(color));
+  }
+
+ private:
+  gfx::Rect rect_;
+};
+
+TEST_F(LayerTreeHostOnDemandRasterPixelTest, RasterPictureLayer) {
+  // Use multiple colors in a single layer to prevent bypassing on-demand
+  // rasterization if a single solid color is detected in picture analysis.
+  gfx::Rect rect(200, 200);

[danakj, 2013/03/21 02:34:42]

can you give this a better name than "rect"?

[Leandro Graciá Gil, 2013/03/21 03:35:50]

Perhaps bounds?

[danakj, 2013/03/21 04:33:39]

I don't think that does more than describe the storage type either. How about
layer_rect?

[Leandro Graciá Gil, 2013/03/21 16:42:48]

Done.

+  BlueYellowLayerClient client(rect);
+  scoped_refptr<PictureLayer> layer = PictureLayer::Create(&client);
+
+  layer->SetIsDrawable(true);
+  layer->SetAnchorPoint(gfx::PointF());
+  layer->SetBounds(rect.size());
+  layer->SetPosition(rect.origin());
+
+  RunPixelTest(layer, base::FilePath(FILE_PATH_LITERAL("blue_yellow.png")));
+}
+
+}  // namespace
+}  // namespace cc
+
+#endif  // OS_ANDROID