Implement on demand quad rasterization for PicturePiles.

cc/test/layer_tree_test_common.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/test/layer_tree_test_common.h"
 
 #include "cc/animation/animation.h"
 #include "cc/animation/animation_registrar.h"
 #include "cc/animation/layer_animation_controller.h"
 #include "cc/animation/timing_function.h"
@@ skipping 298 matching lines @@
 }
 
 ThreadedTest::~ThreadedTest()
 {
 }
 
 void ThreadedTest::endTest()
 {
     // For the case where we endTest during beginTest(), set a flag to indicate that
     // the test should end the second beginTest regains control.
-    if (m_beginning)
+    if (m_beginning) {
         m_endWhenBeginReturns = true;
-    else
-        proxy()->MainThread()->PostTask(base::Bind(&ThreadedTest::realEndTest, m_mainThreadWeakPtr));
+    } else {

[danakj, 2013/03/21 02:34:42]

else if (proxy())

[Leandro Graciá Gil, 2013/03/21 16:42:48]

Done in a separate CL.

+        // Racy timeouts and explicit endTest calls might have cleaned up the tree host.

[nduca, 2013/03/21 02:22:48]

Erm,.... this is a separate patch. You should put that up separately.

[Leandro Graciá Gil, 2013/03/21 03:35:50]

Ok, but the problem was exposed by the newly introduced pixel test. If you're
fine with uploading the fix alone I can land it in a separate patch.

[danakj, 2013/03/21 04:33:39]

I was wondering about this.. does this mean the pixel test is finishing at the
time limit of the timeout? Seems like its going to time out on the bots a lot if
that's the case. Also seems incredibly slow.. I agree it could be a separate CL
(and if that's true, then maybe we need a longer time out on the pixel tests :(
?)

[Leandro Graciá Gil, 2013/03/21 16:42:48]

The new pixel test had flaky crashes, apparently because of a race condition
between timeout calling endTest and the test finishing and calling this same
method. It was easy to reproduce by running the test about 10 times. However, in
case it helps, it was very hard to reproduce when attached to gdb. I had to set
it to repeat 10000 times and go for lunch in order to get a flake in that case.

I'll be moving this into a separate CL as suggested.

+        if (proxy())
+            proxy()->MainThread()->PostTask(base::Bind(&ThreadedTest::realEndTest, m_mainThreadWeakPtr));
+    }
 }
 
 void ThreadedTest::endTestAfterDelay(int delayMilliseconds)
 {
     proxy()->MainThread()->PostTask(base::Bind(&ThreadedTest::endTest, m_mainThreadWeakPtr));
 }
 
 void ThreadedTest::postAddAnimationToMainThread(Layer* layerToReceiveAnimation)
 {
     proxy()->MainThread()->PostTask(base::Bind(&ThreadedTest::dispatchAddAnimation, m_mainThreadWeakPtr, base::Unretained(layerToReceiveAnimation)));
@@ skipping 186 matching lines @@
     ASSERT_FALSE(m_layerTreeHost.get());
     m_client.reset();
     if (m_timedOut) {
         FAIL() << "Test timed out";
         return;
     }
     afterTest();
 }
 
 }  // namespace cc