Implement on demand quad rasterization for PicturePiles.

cc/quads/tile_draw_quad_base.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CC_QUADS_TILE_DRAW_QUAD_BASE_H_
+#define CC_QUADS_TILE_DRAW_QUAD_BASE_H_
+
+#include "base/memory/scoped_ptr.h"
+#include "cc/base/cc_export.h"
+#include "cc/quads/draw_quad.h"
+#include "third_party/khronos/GLES2/gl2.h"
+#include "ui/gfx/point.h"
+#include "ui/gfx/size.h"
+
+namespace cc {
+
+class CC_EXPORT TileDrawQuadBase : public DrawQuad {

[danakj, 2013/03/21 02:34:42]

Since this is the base for more than the TileDrawQuad, I feel like a better name
could be had, but I'm not sure what "class" Tile and Picture are a part of, so
the best I could come up with was TileOrPictureDrawQuadBase.

[Leandro Graciá Gil, 2013/03/21 03:35:50]

Well, this is actually a base class for tile draw quads. The difference later is
that one subclass is backed by a resource id and the other by a PicturePileImpl
and the information required to rasterize it.

[danakj, 2013/03/21 04:33:39]

Right, but the latter isn't called a TileDrawQuad or anything like it, it's
called a PictureDrawQuad. I'd like the name of this class to somehow reflect
that it's more than a base class for the "TileDrawQuad" class.

Maybe the other quad should be TileOnDemandDrawQuad or something, that would be
more clear also.. but I don't mind PictureDrawQuad at all for it.

[Leandro Graciá Gil, 2013/03/21 16:42:48]

I've considered renaming all references to picture to something like
"on-demand", but that ends hiding that a PicturePileImpl is being rasterized.

I suggest we could name that TilePictureDrawQuad to make things clearer. The
base class could then become something like TiledContentDrawQuad, and then,
PICTURE_CONTENT should probably be named TILED_PICTURE_CONTENT or something
similar. Let me know what you think.

[danakj, 2013/03/21 17:20:22]

I had a chat with enne@ about this and we're thinking ContentDrawQuadBase for
this class. Keep the subclasses as is - TileDrawQuad/PictureDrawQuad.

(enne@ pointed out that picture quads will often be the whole layer, not tiles,
as TILED_PICTURE_CONTENT would seem to hint at, so keeping it as PictureDrawQuad
seems nicer.)

+ public:
+  void SetNew(const SharedQuadState* shared_quad_state,
+              DrawQuad::Material material,
+              const gfx::Rect& rect,

[danakj, 2013/03/21 02:34:42]

dont change these types from TileDrawQuad

[Leandro Graciá Gil, 2013/03/21 16:42:48]

Done.

+              const gfx::Rect& opaque_rect,
+              const gfx::RectF& tex_coord_rect,
+              const gfx::Size& texture_size,
+              bool swizzle_contents);
+
+  void SetAll(const SharedQuadState* shared_quad_state,
+              DrawQuad::Material material,
+              const gfx::Rect& rect,
+              const gfx::Rect& opaque_rect,
+              const gfx::Rect& visible_rect,
+              bool needs_blending,
+              const gfx::RectF& tex_coord_rect,
+              const gfx::Size& texture_size,
+              bool swizzle_contents);
+
+  gfx::RectF tex_coord_rect;
+  gfx::Size texture_size;
+  bool swizzle_contents;
+
+ protected:
+  TileDrawQuadBase();
+  virtual ~TileDrawQuadBase();
+};
+
+}
+
+#endif  // CC_QUADS_TILE_DRAW_QUAD_BASE_H_