Implement on demand quad rasterization for PicturePiles.

content/common/cc_messages.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/cc_messages.h"
 
 #include "cc/compositor_frame.h"
 #include "content/public/common/common_param_traits.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebData.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebFilterOperations.h"
@@ skipping 318 matching lines @@
         break;
       case cc::DrawQuad::TILED_CONTENT:
         WriteParam(m, *cc::TileDrawQuad::MaterialCast(quad));
         break;
       case cc::DrawQuad::STREAM_VIDEO_CONTENT:
         WriteParam(m, *cc::StreamVideoDrawQuad::MaterialCast(quad));
         break;
       case cc::DrawQuad::YUV_VIDEO_CONTENT:
         WriteParam(m, *cc::YUVVideoDrawQuad::MaterialCast(quad));
         break;
+      case cc::DrawQuad::PICTURE_CONTENT:
+        NOTREACHED();

[Leandro Graciá Gil, 2013/03/13 20:30:38]

Cannot write or read PictureDrawQuads because they hold a reference-counted
PicturePileImpl object.

+        break;
       case cc::DrawQuad::INVALID:
         break;
     }
 
     const cc::ScopedPtrVector<cc::SharedQuadState>& sqs_list =
         p.shared_quad_state_list;
 
     // This is an invalid index.
     size_t bad_index = sqs_list.size();
 
@@ skipping 94 matching lines @@
         break;
       case cc::DrawQuad::TILED_CONTENT:
         draw_quad = ReadDrawQuad<cc::TileDrawQuad>(m, iter);
         break;
       case cc::DrawQuad::STREAM_VIDEO_CONTENT:
         draw_quad = ReadDrawQuad<cc::StreamVideoDrawQuad>(m, iter);
         break;
       case cc::DrawQuad::YUV_VIDEO_CONTENT:
         draw_quad = ReadDrawQuad<cc::YUVVideoDrawQuad>(m, iter);
         break;
+      case cc::DrawQuad::PICTURE_CONTENT:
+        NOTREACHED();

[piman, 2013/03/15 03:51:57]

drive-by: Not NOTREACHED since a compromized renderer could still send that, and
possibly try to use it for a privilege escalation.
Return false here instead to refuse the message (rather than continue on
inconsistent data).

[Leandro Graciá Gil, 2013/03/19 17:30:07]

Done.

+        break;
       case cc::DrawQuad::INVALID:
         break;
     }
     if (!draw_quad)
       return false;
 
     size_t shared_quad_state_index;
     if (!ReadParam(m, iter, &shared_quad_state_index) ||
         shared_quad_state_index >= p->shared_quad_state_list.size())
       return false;
@@ skipping 59 matching lines @@
         break;
       case cc::DrawQuad::TILED_CONTENT:
         LogParam(*cc::TileDrawQuad::MaterialCast(quad), l);
         break;
       case cc::DrawQuad::STREAM_VIDEO_CONTENT:
         LogParam(*cc::StreamVideoDrawQuad::MaterialCast(quad), l);
         break;
       case cc::DrawQuad::YUV_VIDEO_CONTENT:
         LogParam(*cc::YUVVideoDrawQuad::MaterialCast(quad), l);
         break;
+      case cc::DrawQuad::PICTURE_CONTENT:
+        NOTREACHED();
+        break;
       case cc::DrawQuad::INVALID:
         break;
     }
   }
   l->append("])");
 }
 
 namespace {
   enum CompositorFrameType {
     NO_FRAME,
@@ skipping 137 matching lines @@
   l->append(", [");
   for (size_t i = 0; i < p.render_pass_list.size(); ++i) {
     if (i)
       l->append(", ");
     LogParam(*p.render_pass_list[i], l);
   }
   l->append("])");
 }
 
 }  // namespace IPC