Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1264143003: Fix possible reconcilor loop when the primary account is in an auth error state. (Closed)

Created:
5 years, 4 months ago by Roger Tawa OOO till Jul 10th
Modified:
5 years, 3 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix possible reconcilor loop when the primary account is in an auth error state. BUG=516070, 529439 Committed: https://crrev.com/b32365ef9d9117c4b78cbee77361fd401e8841a2 Cr-Commit-Position: refs/heads/master@{#348441}

Patch Set 1 #

Patch Set 2 : Fix possible reconcilor loop when the primary account is in an auth error state. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -23 lines) Patch
M components/signin/core/browser/gaia_cookie_manager_service.cc View 1 chunk +5 lines, -23 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
nyquist
lgtm
5 years, 4 months ago (2015-07-31 23:39:52 UTC) #2
Roger Tawa OOO till Jul 10th
Hi Tommy, This is the CL you had reviewed a while back, which Jason had ...
5 years, 3 months ago (2015-09-11 16:57:30 UTC) #6
nyquist
lgtm
5 years, 3 months ago (2015-09-11 17:06:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264143003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264143003/80001
5 years, 3 months ago (2015-09-11 17:11:39 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:80001)
5 years, 3 months ago (2015-09-11 18:28:16 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b32365ef9d9117c4b78cbee77361fd401e8841a2 Cr-Commit-Position: refs/heads/master@{#348441}
5 years, 3 months ago (2015-09-11 18:29:14 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:24:26 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b32365ef9d9117c4b78cbee77361fd401e8841a2
Cr-Commit-Position: refs/heads/master@{#348441}

Powered by Google App Engine
This is Rietveld 408576698